mirror/imgui
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2026-02-08 04:40:09 +00:00
Code Activity

Clipper, Tables: removed row_increase >= 0 assert. (#8886)

Browse source 
Seeing cases in my own tests that are not obvious so it seems like too much of a burden for the user to assert/crash, as the row count is not always useful anyhow.
This commit is contained in:
ocornut 2025-08-27 20:31:05 +02:00
parent 55cbc66508
commit 6351f00ff1
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
imgui.cpp
View file

@ -3142,10 +3142,9 @@ static void ImGuiListClipper_SeekCursorAndSetupPrevLine(ImGuiListClipper* clippe
{
if (table->IsInsideRow)
ImGui::TableEndRow(table);
if ((clipper->Flags & ImGuiListClipperFlags_NoSetTableRowCounters) == 0)
const int row_increase = (int)((off_y / line_height) + 0.5f);
if (row_increase > 0 && (clipper->Flags & ImGuiListClipperFlags_NoSetTableRowCounters) == 0) // If your clipper item height is != from actual table row height, consider using ImGuiListClipperFlags_NoSetTableRowCounters. See #8886.
{
const int row_increase = (int)((off_y / line_height) + 0.5f);
IM_ASSERT(row_increase >= 0); // If your clipper item height is != from actual table row height, consider using ImGuiListClipperFlags_NoSetTableRowCounters. See #8886.
table->CurrentRow += row_increase;
table->RowBgColorCounter += row_increase;
}