mirror/imgui
1
0
Fork 0
mirror of https://github.com/ocornut/imgui.git synced 2026-01-11 00:04:24 +00:00
Code Activity

Backends: Include imgui.h in implementation headers. (#3105)

Browse source 
Currently, the implementation headers don't include the imgui.h header.
Which means that the compilation will fail if the implementation header
was included before the imgui.h header in the compilation unit. For
instance, a compilation unit with the following will work:

  #include "imgui.h"
  #include "imgui_impl_glfw.h"
  #include "imgui_impl_opengl3.h"

But a compilation unit with the following will fail because IMGUI_IMPL_API
and possibly other symbols will not be defined:

  #include "imgui_impl_glfw.h"
  #include "imgui_impl_opengl3.h"
  #include "imgui.h"

This patch includes imgui.h in the implementation headers to make
inclusions order-invariant, which is a recommended practice.
This commit is contained in:
OmarEmaraDev 2020-04-06 20:23:57 +02:00 • committed by omar
parent 752436219d
commit 00927105ba
15 changed files with 29 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
examples/imgui_impl_osx.h
View file

@ -8,6 +8,8 @@
// Issues:
// [ ] Platform: Keys are all generally very broken. Best using [event keycode] and not [event characters]..
#include "imgui.h"
@class NSEvent;
@class NSView;