mirror of
https://github.com/juce-framework/JUCE.git
synced 2026-02-03 03:30:06 +00:00
5c34248d00
I observed a deadlock when scanning AU plugins in-process in the AudioPluginHost, and then clicking the "cancel" button in the scan progress alert window. The cause of the deadlock seems to be that JUCE uses async messages to create and destroy AU plugins on the main thread. When running a plugin scanner on a background thread, it was possible to end up in a situation where the background thread was waiting on the message thread to process a create/destroy message; and, at the same time, the main thread was blocked waiting for all scan jobs to complete. This seemed to happen because scanFinished() was called directly from the Scanner's timerCallback as soon as the progress window was cancelled, even if there was still a scan in progress at that point. To avoid the deadlock, we now wait until the current scan has completely finished before allowing the timerCallback to call scanFinished(). If no scan is in progress, then the main thread can safely destroy the scanner ThreadPool without needing to wait at that point. |
||
|---|---|---|
| .. | ||
| juce_KnownPluginList.cpp | ||
| juce_KnownPluginList.h | ||
| juce_PluginDirectoryScanner.cpp | ||
| juce_PluginDirectoryScanner.h | ||
| juce_PluginListComponent.cpp | ||
| juce_PluginListComponent.h | ||