From e730962921d589893f017dc3a5cca5cd5a499f70 Mon Sep 17 00:00:00 2001
From: reuk <reuk@users.noreply.github.com>
Date: Wed, 5 Jan 2022 15:22:44 +0000
Subject: [PATCH] NSViewComponentPeer:  Avoid triggering NSBeeps on unhandled
 key presses

---
 .../native/juce_mac_NSViewComponentPeer.mm    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm b/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm
index 14837d969d..0e88cb6b70 100644
--- a/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm
+++ b/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm
@@ -2317,6 +2317,8 @@ struct JuceNSWindowClass   : public NSViewComponentPeerWrapper<ObjCClass<NSWindo
         addMethod (@selector (accessibilityRole),                   getAccessibilityRole);
         addMethod (@selector (accessibilitySubrole),                getAccessibilitySubrole);
 
+        addMethod (@selector (keyDown:),                            keyDown);
+
         addMethod (@selector (window:shouldDragDocumentWithEvent:from:withPasteboard:), shouldAllowIconDrag);
 
         addProtocol (@protocol (NSWindowDelegate));
@@ -2328,6 +2330,29 @@ private:
     //==============================================================================
     static BOOL isFlipped (id, SEL) { return true; }
 
+    // Key events will be processed by the peer's component.
+    // If the component is unable to use the event, it will be re-sent
+    // to performKeyEquivalent.
+    // performKeyEquivalent will send the event to the view's superclass,
+    // which will try passing the event to the main menu.
+    // If the event still hasn't been processed, it will be passed to the
+    // next responder in the chain, which will be the NSWindow for a peer
+    // that is on the desktop.
+    // If the NSWindow still doesn't handle the event, the Apple docs imply
+    // that the event should be sent to the NSApp for processing, but this
+    // doesn't seem to happen for keyDown events.
+    // Instead, the NSWindow attempts to process the event, fails, and
+    // triggers an annoying NSBeep.
+    // Overriding keyDown to "handle" the event seems to suppress the beep.
+    static void keyDown (id, SEL, NSEvent* ev)
+    {
+        ignoreUnused (ev);
+
+       #if JUCE_DEBUG_UNHANDLED_KEYPRESSES
+        DBG ("unhandled key down event with keycode: " << [ev keyCode]);
+       #endif
+    }
+
     static NSRect windowWillUseStandardFrame (id self, SEL, NSWindow*, NSRect)
     {
         if (auto* owner = getOwner (self))