From df729be74a2c354780f0ca37eb1ee5d4f67b2abc Mon Sep 17 00:00:00 2001 From: jules Date: Thu, 12 Jul 2012 14:10:46 +0100 Subject: [PATCH] Cleaned-up class inheritance visibilities and encapsulation for some internal classes. --- .../Source/Application/jucer_Application.h | 2 +- .../Source/Project/jucer_NewFileWizard.cpp | 3 - .../Source/Project/jucer_NewFileWizard.h | 4 +- .../Source/Project/jucer_TreeViewTypes.cpp | 4 +- .../Source/demos/RenderingTestComponent.cpp | 2 +- .../jucer_FontPropertyComponent.cpp | 2 +- .../native/juce_mac_CoreAudio.cpp | 2 +- .../format/juce_AudioFormatWriter.cpp | 4 +- .../utility/juce_FakeMouseMoveGenerator.h | 2 +- .../processors/juce_AudioProcessorGraph.h | 7 +- .../juce_GenericAudioProcessorEditor.cpp | 4 +- .../gui/juce_AudioDeviceSelectorComponent.cpp | 10 +- .../gui/juce_AudioDeviceSelectorComponent.h | 10 +- .../gui/juce_AudioThumbnail.cpp | 6 +- .../gui/juce_AudioThumbnailCache.cpp | 4 +- .../gui/juce_AudioThumbnailCache.h | 7 +- .../juce_data_structures/values/juce_Value.h | 2 +- .../values/juce_ValueTree.cpp | 12 +- .../juce_InterprocessConnection.h | 2 +- modules/juce_graphics/colour/juce_Colour.cpp | 197 +++++++++--------- modules/juce_graphics/fonts/juce_Font.cpp | 2 +- .../juce_graphics/images/juce_ImageCache.cpp | 4 +- .../juce_graphics/native/juce_linux_Fonts.cpp | 2 +- .../commands/juce_KeyPressMappingSet.h | 2 +- .../components/juce_Desktop.cpp | 7 +- .../components/juce_ModalComponentManager.h | 4 +- .../filebrowser/juce_DirectoryContentsList.h | 5 +- .../filebrowser/juce_FileChooserDialogBox.h | 27 +-- .../filebrowser/juce_FileListComponent.cpp | 18 +- .../filebrowser/juce_FileListComponent.h | 27 +-- .../filebrowser/juce_FileTreeComponent.cpp | 6 +- .../keyboard/juce_CaretComponent.h | 6 +- .../layout/juce_MultiDocumentPanel.cpp | 6 +- .../layout/juce_MultiDocumentPanel.h | 4 +- .../lookandfeel/juce_LookAndFeel.cpp | 8 +- .../lookandfeel/juce_LookAndFeel.h | 3 + .../juce_gui_basics/menus/juce_PopupMenu.cpp | 4 +- .../juce_gui_basics/menus/juce_PopupMenu.h | 2 + .../misc/juce_DropShadower.cpp | 2 +- .../juce_gui_basics/misc/juce_DropShadower.h | 2 + .../mouse/juce_DragAndDropContainer.cpp | 4 +- .../mouse/juce_DragAndDropContainer.h | 1 + .../mouse/juce_MouseInputSource.cpp | 2 +- .../native/juce_mac_Windowing.mm | 2 +- .../native/juce_win32_Windowing.cpp | 2 +- .../juce_ChoicePropertyComponent.cpp | 13 +- .../properties/juce_PropertyPanel.cpp | 34 +-- .../properties/juce_PropertyPanel.h | 2 + .../properties/juce_TextPropertyComponent.cpp | 8 +- .../properties/juce_TextPropertyComponent.h | 9 +- .../juce_gui_basics/widgets/juce_ListBox.cpp | 20 +- .../juce_gui_basics/widgets/juce_ListBox.h | 1 + .../widgets/juce_TableHeaderComponent.cpp | 2 +- .../widgets/juce_TableHeaderComponent.h | 1 + .../widgets/juce_TableListBox.cpp | 24 +-- .../widgets/juce_TableListBox.h | 3 + .../widgets/juce_TextEditor.cpp | 2 +- .../juce_gui_basics/widgets/juce_Toolbar.cpp | 28 +-- .../juce_gui_basics/widgets/juce_Toolbar.h | 10 +- .../widgets/juce_ToolbarItemComponent.cpp | 2 +- .../widgets/juce_ToolbarItemComponent.h | 1 + .../juce_gui_basics/widgets/juce_TreeView.cpp | 20 +- .../juce_gui_basics/widgets/juce_TreeView.h | 11 +- .../windows/juce_TopLevelWindow.cpp | 32 ++- .../misc/juce_ColourSelector.cpp | 39 ++-- .../juce_gui_extra/misc/juce_ColourSelector.h | 3 + .../misc/juce_KeyMappingEditorComponent.cpp | 4 +- .../juce_gui_extra/misc/juce_SplashScreen.h | 8 +- .../misc/juce_WebBrowserComponent.h | 7 +- .../native/juce_mac_WebBrowserComponent.mm | 8 +- .../native/juce_win32_WebBrowserComponent.cpp | 16 +- .../native/juce_win32_DirectShowComponent.cpp | 2 +- 72 files changed, 373 insertions(+), 375 deletions(-) diff --git a/extras/Introjucer/Source/Application/jucer_Application.h b/extras/Introjucer/Source/Application/jucer_Application.h index cb689022c3..9f94b29cb0 100644 --- a/extras/Introjucer/Source/Application/jucer_Application.h +++ b/extras/Introjucer/Source/Application/jucer_Application.h @@ -488,7 +488,7 @@ public: ScopedPointer appearanceEditorWindow; private: - class AsyncQuitRetrier : public Timer + class AsyncQuitRetrier : private Timer { public: AsyncQuitRetrier() { startTimer (500); } diff --git a/extras/Introjucer/Source/Project/jucer_NewFileWizard.cpp b/extras/Introjucer/Source/Project/jucer_NewFileWizard.cpp index 95b723ebd2..512d022235 100644 --- a/extras/Introjucer/Source/Project/jucer_NewFileWizard.cpp +++ b/extras/Introjucer/Source/Project/jucer_NewFileWizard.cpp @@ -155,11 +155,8 @@ NewFileWizard::NewFileWizard() NewFileWizard::~NewFileWizard() { - clearSingletonInstance(); } -juce_ImplementSingleton_SingleThreaded (NewFileWizard) - void NewFileWizard::addWizardsToMenu (PopupMenu& m) const { for (int i = 0; i < wizards.size(); ++i) diff --git a/extras/Introjucer/Source/Project/jucer_NewFileWizard.h b/extras/Introjucer/Source/Project/jucer_NewFileWizard.h index f207c8a639..67b30819b9 100644 --- a/extras/Introjucer/Source/Project/jucer_NewFileWizard.h +++ b/extras/Introjucer/Source/Project/jucer_NewFileWizard.h @@ -31,15 +31,13 @@ //============================================================================== -class NewFileWizard : public DeletedAtShutdown +class NewFileWizard : private DeletedAtShutdown { public: //============================================================================== NewFileWizard(); ~NewFileWizard(); - juce_DeclareSingleton_SingleThreaded_Minimal (NewFileWizard); - //============================================================================== class Type { diff --git a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp index cac06de00c..e6a91e5241 100644 --- a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp +++ b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp @@ -135,7 +135,7 @@ void GroupTreeViewItem::addCreateFileMenuItems (PopupMenu& m) m.addItem (1002, "Add Existing Files..."); m.addSeparator(); - NewFileWizard::getInstance()->addWizardsToMenu (m); + NewFileWizard().addWizardsToMenu (m); } void GroupTreeViewItem::processCreateFileMenuItem (int menuID) @@ -146,7 +146,7 @@ void GroupTreeViewItem::processCreateFileMenuItem (int menuID) case 1002: browseToAddExistingFiles(); break; default: - NewFileWizard::getInstance()->runWizardFromMenu (menuID, item); + NewFileWizard().runWizardFromMenu (menuID, item); break; } } diff --git a/extras/JuceDemo/Source/demos/RenderingTestComponent.cpp b/extras/JuceDemo/Source/demos/RenderingTestComponent.cpp index 43429bd1ce..cadef5df2f 100644 --- a/extras/JuceDemo/Source/demos/RenderingTestComponent.cpp +++ b/extras/JuceDemo/Source/demos/RenderingTestComponent.cpp @@ -27,7 +27,7 @@ //[MiscUserDefs] You can add your own user definitions and misc code here... class RenderingTestCanvas : public Component, - public Timer + private Timer { public: RenderingTestCanvas (RenderingTestComponent& owner_) diff --git a/extras/the jucer/src/properties/jucer_FontPropertyComponent.cpp b/extras/the jucer/src/properties/jucer_FontPropertyComponent.cpp index 3070780a11..811674b75f 100644 --- a/extras/the jucer/src/properties/jucer_FontPropertyComponent.cpp +++ b/extras/the jucer/src/properties/jucer_FontPropertyComponent.cpp @@ -28,7 +28,7 @@ //============================================================================== -class FontList : public DeletedAtShutdown +class FontList : private DeletedAtShutdown { public: FontList() diff --git a/modules/juce_audio_devices/native/juce_mac_CoreAudio.cpp b/modules/juce_audio_devices/native/juce_mac_CoreAudio.cpp index c1a7e66ccd..ac2090685d 100644 --- a/modules/juce_audio_devices/native/juce_mac_CoreAudio.cpp +++ b/modules/juce_audio_devices/native/juce_mac_CoreAudio.cpp @@ -30,7 +30,7 @@ #endif //============================================================================== -class CoreAudioInternal : public Timer +class CoreAudioInternal : private Timer { public: //============================================================================== diff --git a/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp b/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp index 85505a5dd8..5657a84b17 100644 --- a/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp +++ b/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp @@ -166,8 +166,8 @@ bool AudioFormatWriter::writeFromAudioSampleBuffer (const AudioSampleBuffer& sou } //============================================================================== -class AudioFormatWriter::ThreadedWriter::Buffer : public TimeSliceClient, - public AbstractFifo +class AudioFormatWriter::ThreadedWriter::Buffer : public AbstractFifo, + private TimeSliceClient { public: Buffer (TimeSliceThread& timeSliceThread_, AudioFormatWriter* writer_, int numChannels, int bufferSize_) diff --git a/modules/juce_audio_plugin_client/utility/juce_FakeMouseMoveGenerator.h b/modules/juce_audio_plugin_client/utility/juce_FakeMouseMoveGenerator.h index 1cad74d853..c5549b2845 100644 --- a/modules/juce_audio_plugin_client/utility/juce_FakeMouseMoveGenerator.h +++ b/modules/juce_audio_plugin_client/utility/juce_FakeMouseMoveGenerator.h @@ -30,7 +30,7 @@ //============================================================================== // Helper class to workaround carbon windows not getting mouse-moves.. -class FakeMouseMoveGenerator : public Timer +class FakeMouseMoveGenerator : private Timer { public: FakeMouseMoveGenerator() diff --git a/modules/juce_audio_processors/processors/juce_AudioProcessorGraph.h b/modules/juce_audio_processors/processors/juce_AudioProcessorGraph.h index b224c2fc10..4eb41e2e2c 100644 --- a/modules/juce_audio_processors/processors/juce_AudioProcessorGraph.h +++ b/modules/juce_audio_processors/processors/juce_AudioProcessorGraph.h @@ -46,7 +46,7 @@ AudioProcessorPlayer object. */ class JUCE_API AudioProcessorGraph : public AudioProcessor, - public AsyncUpdater + private AsyncUpdater { public: //============================================================================== @@ -395,9 +395,6 @@ public: void getStateInformation (juce::MemoryBlock& destData); void setStateInformation (const void* data, int sizeInBytes); - /** @internal */ - void handleAsyncUpdate(); - private: //============================================================================== ReferenceCountedArray nodes; @@ -415,9 +412,9 @@ private: MidiBuffer* currentMidiInputBuffer; MidiBuffer currentMidiOutputBuffer; + void handleAsyncUpdate(); void clearRenderingSequence(); void buildRenderingSequence(); - bool isAnInputTo (uint32 possibleInputId, uint32 possibleDestinationId, int recursionCheck) const; JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (AudioProcessorGraph); diff --git a/modules/juce_audio_processors/processors/juce_GenericAudioProcessorEditor.cpp b/modules/juce_audio_processors/processors/juce_GenericAudioProcessorEditor.cpp index 2cea5340ad..c6d2c1e4bc 100644 --- a/modules/juce_audio_processors/processors/juce_GenericAudioProcessorEditor.cpp +++ b/modules/juce_audio_processors/processors/juce_GenericAudioProcessorEditor.cpp @@ -24,8 +24,8 @@ */ class ProcessorParameterPropertyComp : public PropertyComponent, - public AudioProcessorListener, - public Timer + private AudioProcessorListener, + private Timer { public: ProcessorParameterPropertyComp (const String& name, AudioProcessor& owner_, const int index_) diff --git a/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.cpp b/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.cpp index 09ca9c0c10..acb260ca79 100644 --- a/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.cpp +++ b/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.cpp @@ -67,7 +67,7 @@ private: //============================================================================== class AudioDeviceSelectorComponent::MidiInputSelectorComponentListBox : public ListBox, - public ListBoxModel + private ListBoxModel { public: //============================================================================== @@ -196,9 +196,9 @@ struct AudioDeviceSetupDetails //============================================================================== class AudioDeviceSettingsPanel : public Component, - public ChangeListener, - public ComboBoxListener, // (can't use ComboBox::Listener due to idiotic VC2005 bug) - public ButtonListener + private ChangeListener, + private ComboBoxListener, // (can't use ComboBox::Listener due to idiotic VC2005 bug) + private ButtonListener { public: AudioDeviceSettingsPanel (AudioIODeviceType* type_, @@ -661,7 +661,7 @@ private: public: //============================================================================== class ChannelSelectorListBox : public ListBox, - public ListBoxModel + private ListBoxModel { public: enum BoxType diff --git a/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.h b/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.h index 00ba91a848..9811b7bf93 100644 --- a/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.h +++ b/modules/juce_audio_utils/gui/juce_AudioDeviceSelectorComponent.h @@ -37,8 +37,8 @@ @see AudioDeviceManager */ class JUCE_API AudioDeviceSelectorComponent : public Component, - public ComboBoxListener, // (can't use ComboBox::Listener due to idiotic VC2005 bug) - public ChangeListener + private ComboBoxListener, // (can't use ComboBox::Listener due to idiotic VC2005 bug) + private ChangeListener { public: //============================================================================== @@ -78,10 +78,6 @@ public: /** @internal */ void resized(); /** @internal */ - void comboBoxChanged (ComboBox*); - /** @internal */ - void changeListenerCallback (ChangeBroadcaster*); - /** @internal */ void childBoundsChanged (Component*); private: @@ -101,6 +97,8 @@ private: ScopedPointer midiOutputSelector; ScopedPointer