diff --git a/.github/actions/download_artifacts/action.yaml b/.github/actions/download_artifacts/action.yaml index 75c0003599..0ef75156b1 100644 --- a/.github/actions/download_artifacts/action.yaml +++ b/.github/actions/download_artifacts/action.yaml @@ -27,7 +27,7 @@ runs: input_keys = """${{ inputs.keys }}""" logger.debug(f'Input keys: {input_keys}') - artifact_keys = filter(None, [x.strip() for x in input_keys.split('\n')]) + artifact_keys = list(filter(None, [x.strip() for x in input_keys.split('\n')])) logger.info(f'Downloading keys: {artifact_keys}') api_prefix = 'actions' @@ -35,7 +35,7 @@ runs: for key in artifact_keys: artifact_id = [x['id'] for x in artifacts_info['artifacts'] if x['name'] == key][0] - logger.debug(f'Artifact id: {key}: {artifact_id}') + logger.debug(f'Artifact id for {key}: {artifact_id}') zip_file = f'{key}.zip' download_github_api_request(zip_file, f'{api_prefix}/artifacts/{artifact_id}/zip') logger.debug(f'Unzipping: {zip_file}') diff --git a/.github/workflows/juce_private_build.yml b/.github/workflows/juce_private_build.yml index 715735ff97..18640a04bf 100644 --- a/.github/workflows/juce_private_build.yml +++ b/.github/workflows/juce_private_build.yml @@ -88,7 +88,9 @@ jobs: secrets: inherit cleanup: if: ${{ always() }} - needs: [setup, build, deploy, docs] + needs: [setup, build, deploy, docs, set-commit-status, notify] name: Cleanup uses: juce-framework/JUCE-utils/.github/workflows/cleanup.yml@master + with: + status: ${{ contains(needs.*.result, 'cancelled') && 'cancelled' || (contains(needs.*.result, 'failure') && 'failure' || 'success') }} secrets: inherit