mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Removed some empty ValueTree::Listener methods that are no longer needed

Browse source
This commit is contained in:
ed 2019-03-22 17:28:14 +00:00
parent 20864a2f5f
commit c96bf71488
14 changed files with 6 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

5
extras/Projucer/Source/Application/Windows/jucer_PIPCreatorWindowComponent.h
View file

@ -203,11 +203,6 @@ private:
}
}
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
//==============================================================================
String getFormattedMetadataString() const noexcept
{

1
extras/Projucer/Source/LiveBuildEngine/jucer_CompileEngineClient.cpp
View file

@ -310,7 +310,6 @@ private:
void valueTreeChildAdded (ValueTree&, ValueTree&) override { projectStructureChanged(); }
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override { projectStructureChanged(); }
void valueTreeParentChanged (ValueTree&) override { projectStructureChanged(); }
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
String getGlobalDefs()
{

2
extras/Projucer/Source/Project/UI/Sidebar/jucer_ExporterTreeItems.h
View file

@ -369,8 +369,6 @@ private:
ValueTree exportersTree;
//==========================================================================
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeParentChanged (ValueTree&) override {}
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { refreshIfNeeded (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { refreshIfNeeded (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { refreshIfNeeded (parentTree); }

1
extras/Projucer/Source/Project/UI/Sidebar/jucer_FileTreeItems.h
View file

@ -245,7 +245,6 @@ public:
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { treeChildrenChanged (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { treeChildrenChanged (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { treeChildrenChanged (parentTree); }
void valueTreeParentChanged (ValueTree&) override {}
//==============================================================================
bool mightContainSubItems() override { return item.getNumChildren() > 0; }

6
extras/Projucer/Source/Project/UI/Sidebar/jucer_ProjectTreeItemBase.h
View file

@ -66,12 +66,6 @@ struct ProjectTreeItemBase : public JucerTreeViewBase,
refreshSubItems();
}
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
virtual bool isProjectSettings() const { return false; }
virtual bool isModulesList() const { return false; }

3
extras/Projucer/Source/Project/UI/jucer_HeaderComponent.h
View file

@ -70,9 +70,6 @@ private:
void timerCallback() override;
//==========================================================================
void valueTreePropertyChanged (ValueTree&, const Identifier&) override {}
void valueTreeParentChanged (ValueTree&) override {}
void valueTreeChildAdded (ValueTree& parentTree, ValueTree&) override { updateIfNeeded (parentTree); }
void valueTreeChildRemoved (ValueTree& parentTree, ValueTree&, int) override { updateIfNeeded (parentTree); }
void valueTreeChildOrderChanged (ValueTree& parentTree, int, int) override { updateIfNeeded (parentTree); }

1
extras/Projucer/Source/Project/jucer_Project.cpp
View file

@ -764,7 +764,6 @@ void Project::valueTreePropertyChanged (ValueTree& tree, const Identifier& prope
void Project::valueTreeChildAdded (ValueTree&, ValueTree&) { changed(); }
void Project::valueTreeChildRemoved (ValueTree&, ValueTree&, int) { changed(); }
void Project::valueTreeChildOrderChanged (ValueTree&, int, int) { changed(); }
void Project::valueTreeParentChanged (ValueTree&) {}
//==============================================================================
bool Project::hasProjectBeenModified()

1
extras/Projucer/Source/Project/jucer_Project.h
View file

@ -387,7 +387,6 @@ public:
void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
//==============================================================================
UndoManager* getUndoManagerFor (const ValueTree&) const { return nullptr; }

7
modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp
View file

@ -411,19 +411,12 @@ void AudioProcessorValueTreeState::valueTreeChildAdded (ValueTree& parent, Value
setNewState (tree);
}
void AudioProcessorValueTreeState::valueTreeChildRemoved (ValueTree&, ValueTree&, int)
{
}
void AudioProcessorValueTreeState::valueTreeRedirected (ValueTree& v)
{
if (v == state)
updateParameterConnectionsToChildTrees();
}
void AudioProcessorValueTreeState::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void AudioProcessorValueTreeState::valueTreeParentChanged (ValueTree&) {}
bool AudioProcessorValueTreeState::flushParameterValuesToValueTree()
{
ScopedLock lock (valueTreeChanging);

3
modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.h
View file

@ -535,9 +535,6 @@ private:
void valueTreePropertyChanged (ValueTree&, const Identifier&) override;
void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
void valueTreeRedirected (ValueTree&) override;
void updateParameterConnectionsToChildTrees();

4
modules/juce_data_structures/values/juce_CachedValue.h
View file

@ -197,10 +197,6 @@ private:
Type getTypedValue() const;
void valueTreePropertyChanged (ValueTree& changedTree, const Identifier& changedProperty) override;
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override {}
void valueTreeChildOrderChanged (ValueTree&, int, int) override {}
void valueTreeParentChanged (ValueTree&) override {}
//==============================================================================
JUCE_DECLARE_WEAK_REFERENCEABLE (CachedValue)

12
modules/juce_data_structures/values/juce_ValueTree.cpp
View file

@ -1088,12 +1088,12 @@ ValueTree ValueTree::readFromGZIPData (const void* data, size_t numBytes)
return readFromStream (gzipStream);
}
void ValueTree::Listener::valueTreePropertyChanged (ValueTree&, const Identifier&) {}
void ValueTree::Listener::valueTreeChildAdded (ValueTree&, ValueTree&) {}
void ValueTree::Listener::valueTreeChildRemoved (ValueTree&, ValueTree&, int) {}
void ValueTree::Listener::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void ValueTree::Listener::valueTreeParentChanged (ValueTree&) {}
void ValueTree::Listener::valueTreeRedirected (ValueTree&) {}
void ValueTree::Listener::valueTreePropertyChanged (ValueTree&, const Identifier&) {}
void ValueTree::Listener::valueTreeChildAdded (ValueTree&, ValueTree&) {}
void ValueTree::Listener::valueTreeChildRemoved (ValueTree&, ValueTree&, int) {}
void ValueTree::Listener::valueTreeChildOrderChanged (ValueTree&, int, int) {}
void ValueTree::Listener::valueTreeParentChanged (ValueTree&) {}
void ValueTree::Listener::valueTreeRedirected (ValueTree&) {}
//==============================================================================
#if JUCE_UNIT_TESTS

2
modules/juce_data_structures/values/juce_ValueTreeSynchroniser.cpp
View file

@ -159,8 +159,6 @@ void ValueTreeSynchroniser::valueTreeChildOrderChanged (ValueTree& parent, int o
stateChanged (m.getData(), m.getDataSize());
}
void ValueTreeSynchroniser::valueTreeParentChanged (ValueTree&) {} // (No action needed here)
bool ValueTreeSynchroniser::applyChange (ValueTree& root, const void* data, size_t dataSize, UndoManager* undoManager)
{
MemoryInputStream input (data, dataSize, false);

1
modules/juce_data_structures/values/juce_ValueTreeSynchroniser.h
View file

@ -91,7 +91,6 @@ private:
void valueTreeChildAdded (ValueTree&, ValueTree&) override;
void valueTreeChildRemoved (ValueTree&, ValueTree&, int) override;
void valueTreeChildOrderChanged (ValueTree&, int, int) override;
void valueTreeParentChanged (ValueTree&) override;
JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValueTreeSynchroniser)
};