mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-22 01:34:21 +00:00
Code Activity

Changed some pass-by-references to pass-by-value to improve compiler optimisation.

Browse source
This commit is contained in:
jules 2013-05-22 23:05:53 -06:00
parent 51df5143bf
commit c7506df13f
140 changed files with 757 additions and 756 deletions
Download patch file Download diff file Expand all files Collapse all files

62
modules/juce_data_structures/values/juce_ValueTree.cpp
View file

@ -28,7 +28,7 @@ class ValueTree::SharedObject : public ReferenceCountedObject
public:
typedef ReferenceCountedObjectPtr<SharedObject> Ptr;
explicit SharedObject (const Identifier& t) noexcept
explicit SharedObject (const Identifier t) noexcept
: type (t), parent (nullptr)
{
}
@ -58,14 +58,14 @@ public:
}
}
void sendPropertyChangeMessage (ValueTree& tree, const Identifier& property)
void sendPropertyChangeMessage (ValueTree& tree, const Identifier property)
{
for (int i = valueTreesWithListeners.size(); --i >= 0;)
if (ValueTree* const v = valueTreesWithListeners[i])
v->listeners.call (&ValueTree::Listener::valueTreePropertyChanged, tree, property);
}
void sendPropertyChangeMessage (const Identifier& property)
void sendPropertyChangeMessage (const Identifier property)
{
ValueTree tree (this);
@ -131,17 +131,17 @@ public:
v->listeners.call (&ValueTree::Listener::valueTreeParentChanged, tree);
}
const var& getProperty (const Identifier& name) const noexcept
const var& getProperty (const Identifier name) const noexcept
{
return properties [name];
}
var getProperty (const Identifier& name, const var& defaultReturnValue) const
var getProperty (const Identifier name, const var& defaultReturnValue) const
{
return properties.getWithDefault (name, defaultReturnValue);
}
void setProperty (const Identifier& name, const var& newValue, UndoManager* const undoManager)
void setProperty (const Identifier name, const var& newValue, UndoManager* const undoManager)
{
if (undoManager == nullptr)
{
@ -162,12 +162,12 @@ public:
}
}
bool hasProperty (const Identifier& name) const noexcept
bool hasProperty (const Identifier name) const noexcept
{
return properties.contains (name);
}
void removeProperty (const Identifier& name, UndoManager* const undoManager)
void removeProperty (const Identifier name, UndoManager* const undoManager)
{
if (undoManager == nullptr)
{
@ -210,7 +210,7 @@ public:
setProperty (source.properties.getName(i), source.properties.getValueAt(i), undoManager);
}
ValueTree getChildWithName (const Identifier& typeToMatch) const
ValueTree getChildWithName (const Identifier typeToMatch) const
{
for (int i = 0; i < children.size(); ++i)
{
@ -222,7 +222,7 @@ public:
return ValueTree::invalid;
}
ValueTree getOrCreateChildWithName (const Identifier& typeToMatch, UndoManager* undoManager)
ValueTree getOrCreateChildWithName (const Identifier typeToMatch, UndoManager* undoManager)
{
for (int i = 0; i < children.size(); ++i)
{
@ -237,7 +237,7 @@ public:
}
ValueTree getChildWithProperty (const Identifier& propertyName, const var& propertyValue) const
ValueTree getChildWithProperty (const Identifier propertyName, const var& propertyValue) const
{
for (int i = 0; i < children.size(); ++i)
{
@ -444,7 +444,7 @@ public:
class SetPropertyAction : public UndoableAction
{
public:
SetPropertyAction (SharedObject* const target_, const Identifier& name_,
SetPropertyAction (SharedObject* const target_, const Identifier name_,
const var& newValue_, const var& oldValue_,
const bool isAddingNewProperty_, const bool isDeletingProperty_)
: target (target_), name (name_), newValue (newValue_), oldValue (oldValue_),
@ -616,7 +616,7 @@ ValueTree::ValueTree() noexcept
const ValueTree ValueTree::invalid;
ValueTree::ValueTree (const Identifier& type_)
ValueTree::ValueTree (const Identifier type_)
: object (new ValueTree::SharedObject (type_))
{
jassert (type_.toString().isNotEmpty()); // All objects should be given a sensible type name!
@ -684,7 +684,7 @@ ValueTree ValueTree::createCopy() const
return ValueTree (createCopyIfNotNull (object.get()));
}
bool ValueTree::hasType (const Identifier& typeName) const
bool ValueTree::hasType (const Identifier typeName) const
{
return object != nullptr && object->type == typeName;
}
@ -709,23 +709,23 @@ ValueTree ValueTree::getSibling (const int delta) const
return ValueTree (object->parent->children.getObjectPointer (index));
}
const var& ValueTree::operator[] (const Identifier& name) const
const var& ValueTree::operator[] (const Identifier name) const
{
return object == nullptr ? var::null : object->getProperty (name);
}
const var& ValueTree::getProperty (const Identifier& name) const
const var& ValueTree::getProperty (const Identifier name) const
{
return object == nullptr ? var::null : object->getProperty (name);
}
var ValueTree::getProperty (const Identifier& name, const var& defaultReturnValue) const
var ValueTree::getProperty (const Identifier name, const var& defaultReturnValue) const
{
return object == nullptr ? defaultReturnValue
: object->getProperty (name, defaultReturnValue);
}
ValueTree& ValueTree::setProperty (const Identifier& name, const var& newValue,
ValueTree& ValueTree::setProperty (const Identifier name, const var& newValue,
UndoManager* const undoManager)
{
jassert (name.toString().isNotEmpty()); // Must have a valid property name!
@ -737,12 +737,12 @@ ValueTree& ValueTree::setProperty (const Identifier& name, const var& newValue,
return *this;
}
bool ValueTree::hasProperty (const Identifier& name) const
bool ValueTree::hasProperty (const Identifier name) const
{
return object != nullptr && object->hasProperty (name);
}
void ValueTree::removeProperty (const Identifier& name, UndoManager* const undoManager)
void ValueTree::removeProperty (const Identifier name, UndoManager* const undoManager)
{
if (object != nullptr)
object->removeProperty (name, undoManager);
@ -780,7 +780,7 @@ class ValueTreePropertyValueSource : public Value::ValueSource,
private ValueTree::Listener
{
public:
ValueTreePropertyValueSource (const ValueTree& vt, const Identifier& prop, UndoManager* um)
ValueTreePropertyValueSource (const ValueTree& vt, const Identifier prop, UndoManager* um)
: tree (vt), property (prop), undoManager (um)
{
tree.addListener (this);
@ -800,21 +800,21 @@ private:
UndoManager* const undoManager;
void valueTreePropertyChanged (ValueTree& treeWhosePropertyHasChanged,
const Identifier& changedProperty)
const Identifier& changedProperty) override
{
if (tree == treeWhosePropertyHasChanged && property == changedProperty)
sendChangeMessage (false);
}
void valueTreeChildAdded (ValueTree&, ValueTree&) {}
void valueTreeChildRemoved (ValueTree&, ValueTree&) {}
void valueTreeChildOrderChanged (ValueTree&) {}
void valueTreeParentChanged (ValueTree&) {}
void valueTreeChildAdded (ValueTree&, ValueTree&) override {}
void valueTreeChildRemoved (ValueTree&, ValueTree&) override {}
void valueTreeChildOrderChanged (ValueTree&) override {}
void valueTreeParentChanged (ValueTree&) override {}
JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ValueTreePropertyValueSource)
};
Value ValueTree::getPropertyAsValue (const Identifier& name, UndoManager* const undoManager)
Value ValueTree::getPropertyAsValue (const Identifier name, UndoManager* const undoManager)
{
return Value (new ValueTreePropertyValueSource (*this, name, undoManager));
}
@ -831,17 +831,17 @@ ValueTree ValueTree::getChild (int index) const
: static_cast <SharedObject*> (nullptr));
}
ValueTree ValueTree::getChildWithName (const Identifier& type) const
ValueTree ValueTree::getChildWithName (const Identifier type) const
{
return object != nullptr ? object->getChildWithName (type) : ValueTree::invalid;
}
ValueTree ValueTree::getOrCreateChildWithName (const Identifier& type, UndoManager* undoManager)
ValueTree ValueTree::getOrCreateChildWithName (const Identifier type, UndoManager* undoManager)
{
return object != nullptr ? object->getOrCreateChildWithName (type, undoManager) : ValueTree::invalid;
}
ValueTree ValueTree::getChildWithProperty (const Identifier& propertyName, const var& propertyValue) const
ValueTree ValueTree::getChildWithProperty (const Identifier propertyName, const var& propertyValue) const
{
return object != nullptr ? object->getChildWithProperty (propertyName, propertyValue) : ValueTree::invalid;
}
@ -923,7 +923,7 @@ void ValueTree::removeListener (Listener* listener)
object->valueTreesWithListeners.removeValue (this);
}
void ValueTree::sendPropertyChangeMessage (const Identifier& property)
void ValueTree::sendPropertyChangeMessage (const Identifier property)
{
if (object != nullptr)
object->sendPropertyChangeMessage (property);