From ba50a3536446431be2f462485b95a3c684e2d57d Mon Sep 17 00:00:00 2001
From: Anthony Nicholls <anthony@juce.com>
Date: Tue, 21 Mar 2023 16:16:04 +0000
Subject: [PATCH] Widgets: stop calling repaint in lookAndFeelChanged()

- A repaint will always occur from a lookAndFeelChanged
---
 .../juce_gui_basics/filebrowser/juce_FileBrowserComponent.cpp   | 1 -
 modules/juce_gui_basics/widgets/juce_ComboBox.cpp               | 2 --
 modules/juce_gui_basics/widgets/juce_TextEditor.cpp             | 1 -
 modules/juce_gui_basics/windows/juce_CallOutBox.cpp             | 1 -
 4 files changed, 5 deletions(-)

diff --git a/modules/juce_gui_basics/filebrowser/juce_FileBrowserComponent.cpp b/modules/juce_gui_basics/filebrowser/juce_FileBrowserComponent.cpp
index b56172e477..d55d3db322 100644
--- a/modules/juce_gui_basics/filebrowser/juce_FileBrowserComponent.cpp
+++ b/modules/juce_gui_basics/filebrowser/juce_FileBrowserComponent.cpp
@@ -371,7 +371,6 @@ void FileBrowserComponent::lookAndFeelChanged()
     filenameBox.applyColourToAllText (findColour (filenameBoxTextColourId));
 
     resized();
-    repaint();
 }
 
 //==============================================================================
diff --git a/modules/juce_gui_basics/widgets/juce_ComboBox.cpp b/modules/juce_gui_basics/widgets/juce_ComboBox.cpp
index b6f2654586..4ea4940374 100644
--- a/modules/juce_gui_basics/widgets/juce_ComboBox.cpp
+++ b/modules/juce_gui_basics/widgets/juce_ComboBox.cpp
@@ -402,8 +402,6 @@ void ComboBox::parentHierarchyChanged()
 
 void ComboBox::lookAndFeelChanged()
 {
-    repaint();
-
     {
         std::unique_ptr<Label> newLabel (getLookAndFeel().createComboBoxTextBox (*this));
         jassert (newLabel != nullptr);
diff --git a/modules/juce_gui_basics/widgets/juce_TextEditor.cpp b/modules/juce_gui_basics/widgets/juce_TextEditor.cpp
index 79be3ecca2..82dcd3bc5e 100644
--- a/modules/juce_gui_basics/widgets/juce_TextEditor.cpp
+++ b/modules/juce_gui_basics/widgets/juce_TextEditor.cpp
@@ -1122,7 +1122,6 @@ void TextEditor::lookAndFeelChanged()
 {
     caret.reset();
     recreateCaret();
-    repaint();
 }
 
 void TextEditor::parentHierarchyChanged()
diff --git a/modules/juce_gui_basics/windows/juce_CallOutBox.cpp b/modules/juce_gui_basics/windows/juce_CallOutBox.cpp
index 3bb6c5306b..357101d286 100644
--- a/modules/juce_gui_basics/windows/juce_CallOutBox.cpp
+++ b/modules/juce_gui_basics/windows/juce_CallOutBox.cpp
@@ -99,7 +99,6 @@ int CallOutBox::getBorderSize() const noexcept
 void CallOutBox::lookAndFeelChanged()
 {
     resized();
-    repaint();
 }
 
 void CallOutBox::paint (Graphics& g)