mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

AU Host: Avoid potential UB reads of MIDI data

Browse source
This commit is contained in:
reuk 2025-07-30 15:57:01 +01:00
parent aebba3c875
commit b5ea607dcc
No known key found for this signature in database
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
modules/juce_audio_processors/format_types/juce_AudioUnitPluginFormat.mm
View file

@ -1417,11 +1417,22 @@ public:
for (const auto metadata : midiMessages) for (const auto metadata : midiMessages)
{ {
if (metadata.numBytes <= 3) if (metadata.numBytes <= 3)
{
const auto getByteOrZero = [&metadata] (int index)
{
return index < metadata.numBytes ? metadata.data[index] : (uint8) 0;
};
MusicDeviceMIDIEvent (audioUnit, MusicDeviceMIDIEvent (audioUnit,
metadata.data[0], metadata.data[1], metadata.data[2], getByteOrZero (0),
getByteOrZero (1),
getByteOrZero (2),
(UInt32) metadata.samplePosition); (UInt32) metadata.samplePosition);
}
else else
{
MusicDeviceSysEx (audioUnit, metadata.data, (UInt32) metadata.numBytes); MusicDeviceSysEx (audioUnit, metadata.data, (UInt32) metadata.numBytes);
}
} }
midiMessages.clear(); midiMessages.clear();