From b324a50e82a80322dc68d98326f454e9152f87b9 Mon Sep 17 00:00:00 2001 From: reuk Date: Wed, 31 Aug 2022 15:06:10 +0100 Subject: [PATCH] BailOutChecker: Add checks after callbacks in Slider and ComboBox Co-authored-by: Roland Rabien --- modules/juce_gui_basics/widgets/juce_ComboBox.cpp | 3 +++ modules/juce_gui_basics/widgets/juce_Slider.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/modules/juce_gui_basics/widgets/juce_ComboBox.cpp b/modules/juce_gui_basics/widgets/juce_ComboBox.cpp index e0ff54a418..b6f2654586 100644 --- a/modules/juce_gui_basics/widgets/juce_ComboBox.cpp +++ b/modules/juce_gui_basics/widgets/juce_ComboBox.cpp @@ -630,6 +630,9 @@ void ComboBox::handleAsyncUpdate() if (onChange != nullptr) onChange(); + if (checker.shouldBailOut()) + return; + if (auto* handler = getAccessibilityHandler()) handler->notifyAccessibilityEvent (AccessibilityEvent::valueChanged); } diff --git a/modules/juce_gui_basics/widgets/juce_Slider.cpp b/modules/juce_gui_basics/widgets/juce_Slider.cpp index d1182ec923..11f79ac629 100644 --- a/modules/juce_gui_basics/widgets/juce_Slider.cpp +++ b/modules/juce_gui_basics/widgets/juce_Slider.cpp @@ -363,6 +363,9 @@ public: if (owner.onValueChange != nullptr) owner.onValueChange(); + if (checker.shouldBailOut()) + return; + if (auto* handler = owner.getAccessibilityHandler()) handler->notifyAccessibilityEvent (AccessibilityEvent::valueChanged); }