mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

OpenGLContext: Make getRenderingScale() sensitive to Component transforms

Browse source 
This also reverts commit c456f67c3f.
This commit is contained in:
attila 2024-01-02 11:01:31 +01:00
parent 00e96e7779
commit b0167985b4
3 changed files with 46 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

27
modules/juce_opengl/opengl/juce_OpenGLContext.cpp
View file

@ -459,17 +459,22 @@ public:
const auto localBounds = component.getLocalBounds();
const auto newArea = peer->getComponent().getLocalArea (&component, localBounds).withZeroOrigin() * displayScale;
const auto newScale = [&]
{
#if JUCE_WINDOWS && JUCE_WIN_PER_MONITOR_DPI_AWARE
// Some hosts (Pro Tools 2022.7) do not take the window scaling into account when sizing
// plugin editor windows. The displayScale however seems to be correctly reported even in
// such cases.
return (float) displayScale * Desktop::getInstance().getGlobalScaleFactor();
#else
return (float) displayScale;
#endif
}();
// On Windows some hosts (Pro Tools 2022.7) do not take the current DPI into account
// when sizing plugin editor windows.
//
// Also in plugins on Windows, the plugin HWND's DPI settings generally don't reflect
// the desktop scaling setting and Displays::Display::scale will return an incorrect 1.0
// value. Our plugin wrappers will use a combination of querying the plugin HWND's
// parent HWND (the host HWND), and utilising the scale factor reported by the host
// through the plugin API. This scale is then added as a transformation to the
// AudioProcessorEditor.
//
// Hence, instead of querying the OS for the DPI of the editor window,
// we approximate based on the physical size of the window that was actually provided
// for the context to draw into. This may break if the OpenGL context's component is
// scaled differently in its width and height - but in this case, a single scale factor
// isn't that helpful anyway.
const auto newScale = (float) newArea.getWidth() / (float) localBounds.getWidth();
areaAndScale.set ({ newArea, newScale }, [&]
{

7
modules/juce_opengl/opengl/juce_OpenGLContext.h
View file

@ -271,9 +271,12 @@ public:
void executeOnGLThread (T&& functor, bool blockUntilFinished);
//==============================================================================
/** Returns the scale factor used by the display that is being rendered.
/** Returns a scale factor that relates the context component's size to the number
of physical pixels it covers on the screen.
The scale is that of the display - see Displays::Display::scale
In special cases it will be the same as Displays::Display::scale, but it also
includes AffineTransforms that affect the rendered area, and will be correctly
reported not just in standalone applications but plugins as well.
Note that this should only be called during an OpenGLRenderer::renderOpenGL()
callback - at other times the value it returns is undefined.