From ac612693aa19a7009b103cca3d7e6069a0b4b1cc Mon Sep 17 00:00:00 2001 From: reuk Date: Mon, 23 Nov 2020 13:45:21 +0000 Subject: [PATCH] NamedPipe: Fix potential vptr data-race in unit tests --- modules/juce_core/network/juce_NamedPipe.cpp | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/modules/juce_core/network/juce_NamedPipe.cpp b/modules/juce_core/network/juce_NamedPipe.cpp index 23c84429c6..a6f1cb7ae4 100644 --- a/modules/juce_core/network/juce_NamedPipe.cpp +++ b/modules/juce_core/network/juce_NamedPipe.cpp @@ -210,11 +210,6 @@ private: pipe.openExisting (pipeName); } - ~NamedPipeThread() - { - stopThread (100); - } - NamedPipe pipe; const String& pipeName; WaitableEvent& workCompleted; @@ -231,6 +226,11 @@ private: sendData (sData) {} + ~SenderThread() override + { + stopThread (100); + } + void run() override { result = pipe.write (&sendData, sizeof (sendData), 2000); @@ -248,6 +248,11 @@ private: : NamedPipeThread ("NamePipeSender", pName, shouldCreatePipe, completed) {} + ~ReceiverThread() override + { + stopThread (100); + } + void run() override { result = pipe.read (&recvData, sizeof (recvData), 2000);