diff --git a/extras/Build/juce_build_tools/utils/juce_BinaryResourceFile.cpp b/extras/Build/juce_build_tools/utils/juce_BinaryResourceFile.cpp index e9b03f3396..fa9c3f2eac 100644 --- a/extras/Build/juce_build_tools/utils/juce_BinaryResourceFile.cpp +++ b/extras/Build/juce_build_tools/utils/juce_BinaryResourceFile.cpp @@ -248,10 +248,10 @@ namespace build_tools auto r = writeHeader (mo); if (r.failed()) - return { r }; + return { r, {} }; if (! overwriteFileWithNewDataIfDifferent (headerFile, mo)) - return { Result::fail ("Can't write to file: " + headerFile.getFullPathName()) }; + return { Result::fail ("Can't write to file: " + headerFile.getFullPathName()), {} }; filesCreated.add (headerFile); } diff --git a/modules/juce_audio_formats/codecs/juce_OggVorbisAudioFormat.cpp b/modules/juce_audio_formats/codecs/juce_OggVorbisAudioFormat.cpp index 975b4406c5..22a44c2a7b 100644 --- a/modules/juce_audio_formats/codecs/juce_OggVorbisAudioFormat.cpp +++ b/modules/juce_audio_formats/codecs/juce_OggVorbisAudioFormat.cpp @@ -46,7 +46,8 @@ namespace OggVorbisNamespace "-Wzero-as-null-pointer-constant", "-Wsign-conversion", "-Wswitch-default", - "-Wredundant-decls") + "-Wredundant-decls", + "-Wmisleading-indentation") #include "oggvorbis/vorbisenc.h" #include "oggvorbis/codec.h" diff --git a/modules/juce_audio_formats/format/juce_AudioFormatReader.cpp b/modules/juce_audio_formats/format/juce_AudioFormatReader.cpp index bd4fe169a0..6e381bfecd 100644 --- a/modules/juce_audio_formats/format/juce_AudioFormatReader.cpp +++ b/modules/juce_audio_formats/format/juce_AudioFormatReader.cpp @@ -38,9 +38,11 @@ AudioFormatReader::~AudioFormatReader() static void convertFixedToFloat (int* const* channels, int numChannels, int numSamples) { + constexpr auto scaleFactor = 1.0f / static_cast (0x7fffffff); + for (int i = 0; i < numChannels; ++i) if (auto d = channels[i]) - FloatVectorOperations::convertFixedToFloat (reinterpret_cast (d), d, 1.0f / 0x7fffffff, numSamples); + FloatVectorOperations::convertFixedToFloat (reinterpret_cast (d), d, scaleFactor, numSamples); } bool AudioFormatReader::read (float* const* destChannels, int numDestChannels, diff --git a/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp b/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp index 2ec9b1aaa8..afe3ee7c44 100644 --- a/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp +++ b/modules/juce_audio_formats/format/juce_AudioFormatWriter.cpp @@ -108,8 +108,10 @@ bool AudioFormatWriter::writeFromAudioReader (AudioFormatReader& reader, { void* const b = *bufferChan++; + constexpr auto scaleFactor = 1.0f / static_cast (0x7fffffff); + if (isFloatingPoint()) - FloatVectorOperations::convertFixedToFloat ((float*) b, (int*) b, 1.0f / 0x7fffffff, numToDo); + FloatVectorOperations::convertFixedToFloat ((float*) b, (int*) b, scaleFactor, numToDo); else convertFloatsToInts ((int*) b, (float*) b, numToDo); } diff --git a/modules/juce_audio_processors/format_types/juce_VST3Headers.h b/modules/juce_audio_processors/format_types/juce_VST3Headers.h index 18f13f5eb2..586c0e249b 100644 --- a/modules/juce_audio_processors/format_types/juce_VST3Headers.h +++ b/modules/juce_audio_processors/format_types/juce_VST3Headers.h @@ -52,6 +52,7 @@ JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-Wnon-virtual-dtor", "-Wignored-qualifiers", "-Wmissing-field-initializers", "-Wformat=", + "-Wformat", "-Wpedantic", "-Wextra", "-Wclass-memaccess") diff --git a/modules/juce_core/maths/juce_MathsFunctions.h b/modules/juce_core/maths/juce_MathsFunctions.h index ca6ca67af8..58ee199968 100644 --- a/modules/juce_core/maths/juce_MathsFunctions.h +++ b/modules/juce_core/maths/juce_MathsFunctions.h @@ -521,7 +521,8 @@ template unsigned int truncatePositiveToUnsignedInt (FloatType value) noexcept { jassert (value >= static_cast (0)); - jassert (static_cast (value) <= std::numeric_limits::max()); + jassert (static_cast (value) + <= static_cast (std::numeric_limits::max())); return static_cast (value); } diff --git a/modules/juce_core/maths/juce_Random.cpp b/modules/juce_core/maths/juce_Random.cpp index bd9e3994ed..37c17b6b2b 100644 --- a/modules/juce_core/maths/juce_Random.cpp +++ b/modules/juce_core/maths/juce_Random.cpp @@ -105,7 +105,8 @@ bool Random::nextBool() noexcept float Random::nextFloat() noexcept { - auto result = static_cast (nextInt()) / (std::numeric_limits::max() + 1.0f); + auto result = static_cast (nextInt()) + / (static_cast (std::numeric_limits::max()) + 1.0f); return result == 1.0f ? 1.0f - std::numeric_limits::epsilon() : result; }