mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Add a base clang-tidy configuration

Browse source
This commit is contained in:
Tom Poole 2023-09-11 20:49:49 +01:00
parent 0dfaa98e86
commit 9b041f3d74
73 changed files with 484 additions and 279 deletions
Download patch file Download diff file Expand all files Collapse all files

38
extras/Projucer/Source/ComponentEditor/jucer_ComponentLayout.cpp
View file

@ -48,19 +48,14 @@ void ComponentLayout::changed()
document->changed();
}
void ComponentLayout::perform (UndoableAction* action, const String& actionName)
void ComponentLayout::perform (std::unique_ptr<UndoableAction> action, const String& actionName)
{
jassert (document != nullptr);
if (document != nullptr)
{
document->getUndoManager().perform (action, actionName);
}
document->getUndoManager().perform (action.release(), actionName);
else
{
std::unique_ptr<UndoableAction> deleter (action);
action->perform();
}
}
//==============================================================================
@ -76,8 +71,8 @@ void ComponentLayout::clearComponents()
class AddCompAction : public UndoableAction
{
public:
AddCompAction (XmlElement* const xml_, ComponentLayout& layout_)
: indexAdded (-1),
AddCompAction (XmlElement* const xml_, ComponentLayout& layout_, int& index)
: indexRef (index),
xml (xml_),
layout (layout_)
{
@ -89,21 +84,21 @@ public:
Component* const newComp = layout.addComponentFromXml (*xml, false);
jassert (newComp != nullptr);
indexAdded = layout.indexOfComponent (newComp);
jassert (indexAdded >= 0);
return indexAdded >= 0;
indexRef = layout.indexOfComponent (newComp);
jassert (indexRef >= 0);
return indexRef >= 0;
}
bool undo()
{
showCorrectTab();
layout.removeComponent (layout.getComponent (indexAdded), false);
layout.removeComponent (layout.getComponent (indexRef), false);
return true;
}
int getSizeInUnits() { return 10; }
int indexAdded;
int& indexRef;
private:
std::unique_ptr<XmlElement> xml;
@ -164,7 +159,7 @@ void ComponentLayout::removeComponent (Component* comp, const bool undoable)
{
if (undoable)
{
perform (new DeleteCompAction (comp, *this), "Delete components");
perform (std::make_unique<DeleteCompAction> (comp, *this), "Delete components");
}
else
{
@ -224,7 +219,7 @@ void ComponentLayout::componentToFront (Component* comp, const bool undoable)
if (comp != nullptr && components.contains (comp))
{
if (undoable)
perform (new FrontBackCompAction (comp, *this, -1), "Move components to front");
perform (std::make_unique<FrontBackCompAction> (comp, *this, -1), "Move components to front");
else
moveComponentZOrder (components.indexOf (comp), -1);
}
@ -235,7 +230,7 @@ void ComponentLayout::componentToBack (Component* comp, const bool undoable)
if (comp != nullptr && components.contains (comp))
{
if (undoable)
perform (new FrontBackCompAction (comp, *this, 0), "Move components to back");
perform (std::make_unique<FrontBackCompAction> (comp, *this, 0), "Move components to back");
else
moveComponentZOrder (components.indexOf (comp), 0);
}
@ -432,9 +427,8 @@ Component* ComponentLayout::addComponentFromXml (const XmlElement& xml, const bo
{
if (undoable)
{
AddCompAction* const action = new AddCompAction (new XmlElement (xml), *this);
perform (action, "Add new components");
return components [action->indexAdded];
perform (std::make_unique<AddCompAction> (new XmlElement (xml), *this, addComponentIndexAdded), "Add new components");
return components [addComponentIndexAdded];
}
if (ComponentTypeHandler* const type
@ -667,7 +661,7 @@ void ComponentLayout::setComponentPosition (Component* comp,
{
if (undoable)
{
perform (new ChangeCompPositionAction (comp, *this, newPos), "Move components");
perform (std::make_unique<ChangeCompPositionAction> (comp, *this, newPos), "Move components");
}
else
{
@ -701,7 +695,7 @@ void ComponentLayout::setComponentBoundsAndProperties (Component* componentToPos
{
if (undoable)
{
perform (new ChangeCompBoundsAndPropertiesAction (componentToPosition, *this, newBounds, props), "Change component bounds");
perform (std::make_unique<ChangeCompBoundsAndPropertiesAction> (componentToPosition, *this, newBounds, props), "Change component bounds");
}
else
{