From 96383fb50469ec9dabe6604173acb54325112cd5 Mon Sep 17 00:00:00 2001 From: ed Date: Wed, 22 Dec 2021 09:43:41 +0000 Subject: [PATCH] macOS: Fix nullptr dereference in WebInputStream on macOS versions < 10.10 --- modules/juce_core/native/juce_mac_Network.mm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/juce_core/native/juce_mac_Network.mm b/modules/juce_core/native/juce_mac_Network.mm index edbe8e55b9..58b1799e69 100644 --- a/modules/juce_core/native/juce_mac_Network.mm +++ b/modules/juce_core/native/juce_mac_Network.mm @@ -969,6 +969,7 @@ public: if (! connection->start (owner, webInputListener)) { + const auto errorCode = connection->getErrorCode(); connection.reset(); if (@available (macOS 10.10, *)) @@ -976,7 +977,7 @@ public: // Workaround for macOS versions below 10.10 where HTTPS POST requests with keep-alive // fail with the NSURLErrorNetworkConnectionLost error code. - if (numRetries == 0 && connection->getErrorCode() == NSURLErrorNetworkConnectionLost) + if (numRetries == 0 && errorCode == NSURLErrorNetworkConnectionLost) return connect (webInputListener, ++numRetries); return false;