mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Removed a couple of superfluous methods from AudioProcessor.

Browse source
This commit is contained in:
jules 2015-03-28 09:50:20 +00:00
parent 3a89869bdb
commit 95b4198e2c
4 changed files with 6 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

5
modules/juce_audio_plugin_client/VST/juce_VST_Wrapper.cpp
View file

@ -851,10 +851,9 @@ public:
{
jassert (isPositiveAndBelow (index, filter->getNumParameters()));
float value;
if (filter->valueFromString (index, text, value))
if (AudioProcessorParameter* p = filter->getParameters()[index])
{
filter->setParameter (index, value);
filter->setParameter (index, p->getValueForText (String::fromUTF8 (text)));
return true;
}
}

11
modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp
View file

@ -197,10 +197,8 @@ public:
void toString (Vst::ParamValue value, Vst::String128 result) const override
{
String text;
if (owner.stringFromValue (paramIndex, value, 128, text))
toString128 (result, text);
if (AudioProcessorParameter* p = owner.getParameters()[paramIndex])
toString128 (result, p->getText (value, 128));
else
// remain backward-compatible with old JUCE code
toString128 (result, owner.getParameterText (paramIndex, 128));
@ -208,10 +206,9 @@ public:
bool fromString (const Vst::TChar* text, Vst::ParamValue& valueNormalized) const override
{
float value;
if (owner.valueFromString (paramIndex, getStringFromVstTChars (text), value))
if (AudioProcessorParameter* p = owner.getParameters()[paramIndex])
{
valueNormalized = value;
valueNormalized = p->getValueForText (getStringFromVstTChars (text));
return true;
}

22
modules/juce_audio_processors/processors/juce_AudioProcessor.cpp
View file

@ -397,28 +397,6 @@ XmlElement* AudioProcessor::getXmlFromBinary (const void* data, const int sizeIn
return nullptr;
}
bool AudioProcessor::valueFromString (int index, const String& text, float& value) const
{
if (AudioProcessorParameter* p = managedParameters[index])
{
value = p->getValueForText (text);
return true;
}
return false;
}
bool AudioProcessor::stringFromValue (int index, float value, int maxLen, String& result) const
{
if (AudioProcessorParameter* p = managedParameters[index])
{
result = p->getText (value, maxLen);
return true;
}
return false;
}
//==============================================================================
void AudioProcessorListener::audioProcessorParameterChangeGestureBegin (AudioProcessor*, int) {}
void AudioProcessorListener::audioProcessorParameterChangeGestureEnd (AudioProcessor*, int) {}

6
modules/juce_audio_processors/processors/juce_AudioProcessor.h
View file

@ -663,12 +663,6 @@ public:
/** @internal */
static void JUCE_CALLTYPE setTypeOfNextNewPlugin (WrapperType);
/** @internal */
bool valueFromString (int parameterIndex, const String& text, float& value) const;
/** @internal */
bool stringFromValue (int index, float value, int maxLen, String& result) const;
protected:
/** @internal */
AudioPlayHead* playHead;