mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

VST3 Client: Avoid returning kResultFalse from getCompatibilityJSON

Browse source
This commit is contained in:
reuk 2023-10-16 11:38:05 +01:00
parent 6d0614d1f7
commit 89f19503a2
No known key found for this signature in database
GPG key ID: FCB43929F012EE5C
1 changed files with 24 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

43
modules/juce_audio_plugin_client/juce_audio_plugin_client_VST3.cpp
View file

@ -3965,33 +3965,38 @@ public:
auto filter = createPluginFilterOfType (AudioProcessor::WrapperType::wrapperType_VST3);
auto* extensions = filter->getVST3ClientExtensions();
if (extensions == nullptr || extensions->getCompatibleClasses().empty())
return kResultFalse;
DynamicObject::Ptr object { new DynamicObject };
// New iid is the ID of our Audio Effect class
object->setProperty ("New", String (VST3::UID (JuceVST3Component::iid).toString()));
object->setProperty ("Old", [&]
const auto compatibilityObjects = [&]
{
Array<var> oldArray;
if (extensions == nullptr || extensions->getCompatibleClasses().empty())
return Array<var>();
for (const auto& uid : extensions->getCompatibleClasses())
DynamicObject::Ptr object { new DynamicObject };
// New iid is the ID of our Audio Effect class
object->setProperty ("New", String (VST3::UID (JuceVST3Component::iid).toString()));
object->setProperty ("Old", [&]
{
// All UIDs returned from getCompatibleClasses should be 32 characters long
jassert (uid.length() == 32);
Array<var> oldArray;
// All UIDs returned from getCompatibleClasses should be in hex notation
jassert (uid.containsOnly ("ABCDEF0123456789"));
for (const auto& uid : extensions->getCompatibleClasses())
{
// All UIDs returned from getCompatibleClasses should be 32 characters long
jassert (uid.length() == 32);
oldArray.add (uid);
}
// All UIDs returned from getCompatibleClasses should be in hex notation
jassert (uid.containsOnly ("ABCDEF0123456789"));
return oldArray;
}());
oldArray.add (uid);
}
return oldArray;
}());
return Array<var> { object.get() };
}();
MemoryOutputStream memory;
JSON::writeToStream (memory, var { Array<var> { object.get() } });
JSON::writeToStream (memory, var { compatibilityObjects });
return stream->write (memory.getMemoryBlock().getData(), (Steinberg::int32) memory.getDataSize());
}