From 7b6d41be3f9fd23b5ab725d2dbf07815997af729 Mon Sep 17 00:00:00 2001 From: reuk Date: Mon, 22 Mar 2021 12:25:40 +0000 Subject: [PATCH] AudioBuffer: Make assertions more specific --- .../juce_audio_basics/buffers/juce_AudioSampleBuffer.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/juce_audio_basics/buffers/juce_AudioSampleBuffer.h b/modules/juce_audio_basics/buffers/juce_AudioSampleBuffer.h index acd165ff01..cf6aba827e 100644 --- a/modules/juce_audio_basics/buffers/juce_AudioSampleBuffer.h +++ b/modules/juce_audio_basics/buffers/juce_AudioSampleBuffer.h @@ -751,7 +751,10 @@ public: int numSamples, Type gainToApplyToSource = Type (1)) noexcept { - jassert (&source != this || sourceChannel != destChannel); + jassert (&source != this + || sourceChannel != destChannel + || sourceStartSample + numSamples <= destStartSample + || destStartSample + numSamples <= sourceStartSample); jassert (isPositiveAndBelow (destChannel, numChannels)); jassert (destStartSample >= 0 && numSamples >= 0 && destStartSample + numSamples <= size); jassert (isPositiveAndBelow (sourceChannel, source.numChannels)); @@ -887,7 +890,10 @@ public: int sourceStartSample, int numSamples) noexcept { - jassert (&source != this || sourceChannel != destChannel); + jassert (&source != this + || sourceChannel != destChannel + || sourceStartSample + numSamples <= destStartSample + || destStartSample + numSamples <= sourceStartSample); jassert (isPositiveAndBelow (destChannel, numChannels)); jassert (destStartSample >= 0 && destStartSample + numSamples <= size); jassert (isPositiveAndBelow (sourceChannel, source.numChannels));