mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

ADSR: Fix bug when using applyEnvelopeToBuffer() with zero-length attack and decay

Browse source
This commit is contained in:
ed 2021-10-25 15:41:02 +01:00
parent b70fbb9bca
commit 792f992dfc
2 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
modules/juce_audio_basics/utilities/juce_ADSR.h
View file

@ -124,6 +124,7 @@ public:
}
else
{
envelopeVal = parameters.sustain;
state = State::sustain;
}
}

14
modules/juce_audio_basics/utilities/juce_ADSR_test.cpp
View file

@ -152,6 +152,20 @@ struct ADSRTests : public UnitTest
expect (isSustained (buffer, parameters.sustain));
}
beginTest ("Zero-length attack and decay releases correctly");
{
adsr.reset();
adsr.setParameters ({ 0.0f, 0.0f, parameters.sustain, parameters.release });
adsr.noteOn();
adsr.noteOff();
auto buffer = getTestBuffer (sampleRate, parameters.release);
adsr.applyEnvelopeToBuffer (buffer, 0, buffer.getNumSamples());
expect (isDecreasing (buffer));
}
beginTest ("Zero-length release resets to idle");
{
adsr.reset();