mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

File: Remove broken dynamic load of GetFinalPathNamebyHandle

Browse source
This commit is contained in:
reuk 2024-04-22 19:24:52 +01:00
parent 248a400b88
commit 74da0f977d
No known key found for this signature in database
GPG key ID: FCB43929F012EE5C
1 changed files with 30 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

59
modules/juce_core/native/juce_Files_windows.cpp
View file

@ -911,39 +911,40 @@ static String readWindowsShortcutOrLink (const File& shortcut, bool wantsAbsolut
if (! wantsAbsolutePath)
return readWindowsLnkFile (shortcut, false);
typedef DWORD (WINAPI* GetFinalPathNameByHandleFunc) (HANDLE, LPTSTR, DWORD, DWORD);
auto* h = CreateFile (shortcut.getFullPathName().toWideCharPointer(),
GENERIC_READ, FILE_SHARE_READ, nullptr,
OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, nullptr);
static GetFinalPathNameByHandleFunc getFinalPathNameByHandle
= (GetFinalPathNameByHandleFunc) getUser32Function ("GetFinalPathNameByHandle");
if (getFinalPathNameByHandle != nullptr)
const ScopeGuard scope { [&]
{
HANDLE h = CreateFile (shortcut.getFullPathName().toWideCharPointer(),
GENERIC_READ, FILE_SHARE_READ, nullptr,
OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, nullptr);
if (h != INVALID_HANDLE_VALUE)
{
if (DWORD requiredSize = getFinalPathNameByHandle (h, nullptr, 0, 0 /* FILE_NAME_NORMALIZED */))
{
HeapBlock<WCHAR> buffer (requiredSize + 2, true);
if (getFinalPathNameByHandle (h, buffer, requiredSize, 0 /* FILE_NAME_NORMALIZED */) > 0)
{
CloseHandle (h);
const StringRef prefix ("\\\\?\\");
const String path (buffer.get());
// It turns out that GetFinalPathNameByHandleW prepends \\?\ to the path.
// This is not a bug, it's feature. See MSDN for more information.
return path.startsWith (prefix) ? path.substring (prefix.length()) : path;
}
}
CloseHandle (h);
}
}
} };
const auto path = [&]() -> String
{
if (h == INVALID_HANDLE_VALUE)
return {};
const auto requiredSize = GetFinalPathNameByHandle (h, nullptr, 0, 0 /* FILE_NAME_NORMALIZED */);
if (requiredSize == 0)
return {};
std::vector<WCHAR> buffer (requiredSize + 2, 0);
if (GetFinalPathNameByHandle (h, buffer.data(), requiredSize, 0 /* FILE_NAME_NORMALIZED */) <= 0)
return {};
return buffer.data();
}();
static constexpr const char* prefix ("\\\\?\\");
// It turns out that GetFinalPathNameByHandleW prepends \\?\ to the path.
// This is not a bug, it's a feature. See MSDN for more information.
if (path.isNotEmpty())
return path.startsWith (prefix) ? path.substring (StringRef (prefix).length()) : path;
#endif
// as last resort try the resolve method of the ShellLink