mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

GenericAudioProcessorEditor: Avoid creating choice parameter components for discrete parameters with large numbers of steps

Browse source
This commit is contained in:
reuk 2025-06-03 14:48:36 +01:00
parent b349531966
commit 6cd9566868
No known key found for this signature in database
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
modules/juce_audio_processors/processors/juce_GenericAudioProcessorEditor.cpp
View file

@ -490,9 +490,18 @@ private:
// If we have a list of strings to represent the different states a
// parameter can be in then we should present a dropdown allowing a
// user to pick one of them.
if (! parameter.getAllValueStrings().isEmpty()
&& std::abs (parameter.getNumSteps() - parameter.getAllValueStrings().size()) <= 1)
return std::make_unique<ChoiceParameterComponent> (processor, parameter);
// We limit the number of items in the dropdown to avoid having to
// build and display an overly-large menu.
constexpr auto arbitraryDiscreteChoiceThreshold = 1000;
if (const auto numSteps = parameter.getNumSteps();
numSteps < arbitraryDiscreteChoiceThreshold)
{
const auto valueStrings = parameter.getAllValueStrings();
if (! valueStrings.isEmpty() && std::abs (numSteps - valueStrings.size()) <= 1)
return std::make_unique<ChoiceParameterComponent> (processor, parameter);
}
// Everything else can be represented as a slider.
return std::make_unique<SliderParameterComponent> (processor, parameter);