From 69297d6790685132b3c53ba9584e5c818fbdb8a5 Mon Sep 17 00:00:00 2001 From: jules Date: Thu, 23 Feb 2017 16:40:52 +0000 Subject: [PATCH] Added an assertion to MidiMessage to help catch float/int parameter confusion --- modules/juce_audio_basics/midi/juce_MidiMessage.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/juce_audio_basics/midi/juce_MidiMessage.cpp b/modules/juce_audio_basics/midi/juce_MidiMessage.cpp index 07e4f26217..1d80f33499 100644 --- a/modules/juce_audio_basics/midi/juce_MidiMessage.cpp +++ b/modules/juce_audio_basics/midi/juce_MidiMessage.cpp @@ -44,6 +44,9 @@ namespace MidiHelpers //============================================================================== uint8 MidiMessage::floatValueToMidiByte (const float v) noexcept { + jassert (v >= 0 && v <= 1.0f); // if your value is > 1, maybe you're passing an + // integer value to a float method by mistake? + return MidiHelpers::validVelocity (roundToInt (v * 127.0f)); }