Projucer: Accessibility updates

extras/Projucer/Source/Application/StartPage/jucer_ContentComponents.h

@@ -254,6 +254,9 @@ public:
           header (metadata[Ids::name].toString(), metadata[Ids::description].toString(), BinaryData::background_logo_svg),
           codeViewer (doc, &cppTokeniser)
     {
+        setTitle (exampleFile.getFileName());
+        setFocusContainerType (FocusContainerType::focusContainer);
+
         addAndMakeVisible (header);
 
         openExampleButton.onClick = [this] { exampleSelectedCallback (exampleFile); };
@@ -286,6 +289,7 @@ private:
 
         codeViewer.setScrollbarThickness (6);
         codeViewer.setReadOnly (true);
+        codeViewer.setTitle ("Code");
         getAppSettings().appearance.applyToCodeEditor (codeViewer);
 
         codeViewer.scrollToLine (findBestLineToScrollToForClass (StringArray::fromLines (fileString),

extras/Projucer/Source/Application/StartPage/jucer_StartPageComponent.cpp

@@ -34,6 +34,12 @@
 //==============================================================================
 struct ContentComponent  : public Component
 {
+    ContentComponent()
+    {
+        setTitle ("Content");
+        setFocusContainerType (FocusContainerType::focusContainer);
+    }
+
     void resized() override
     {
         if (content != nullptr)
@@ -88,7 +94,8 @@ static std::unique_ptr<Component> createExampleProjectsTab (ContentComponent& co
         content.setContent (std::make_unique<ExampleComponent> (findExampleFile (category, index), cb));
     };
 
-    return std::make_unique<StartPageTreeHolder> (exampleCategories,
+    return std::make_unique<StartPageTreeHolder> ("Examples",
+                                                  exampleCategories,
                                                   examples,
                                                   std::move (selectedCallback),
                                                   StartPageTreeHolder::Open::no);
@@ -144,7 +151,8 @@ static std::unique_ptr<Component> createProjectTemplatesTab (ContentComponent& c
         content.setContent (std::make_unique<TemplateComponent> (templates[(size_t) index], std::move (cb)));
     };
 
-    auto holder = std::make_unique<StartPageTreeHolder> (categories,
+    auto holder = std::make_unique<StartPageTreeHolder> ("Templates",
+                                                         categories,
                                                          templateNames,
                                                          std::move (selectedCallback),
                                                          StartPageTreeHolder::Open::yes);
@@ -165,7 +173,14 @@ struct ProjectTemplatesAndExamples  : public TabbedComponent
           content (c),
           exampleSelectedCallback (std::move (exampleCb))
     {
-        addTab ("New Project", Colours::transparentBlack, createProjectTemplatesTab (content, std::move (newProjectCb)).release(), true);
+        setTitle ("Templates and Examples");
+        setFocusContainerType (FocusContainerType::focusContainer);
+
+        addTab ("New Project",
+                Colours::transparentBlack,
+                createProjectTemplatesTab (content, std::move (newProjectCb)).release(),
+                true);
+
         refreshExamplesTab();
     }
 
@@ -177,8 +192,9 @@ struct ProjectTemplatesAndExamples  : public TabbedComponent
 
         auto exampleTabs = createExampleProjectsTab (content, exampleSelectedCallback);
 
-        addTab ("Open Example", Colours::transparentBlack, exampleTabs == nullptr ? new SetJUCEPathComponent (*this)
-                                                                                  : exampleTabs.release(),
+        addTab ("Open Example",
+                Colours::transparentBlack,
+                exampleTabs == nullptr ? new SetJUCEPathComponent (*this) : exampleTabs.release(),
                 true);
 
         if (wasOpen)

extras/Projucer/Source/Application/StartPage/jucer_StartPageTreeHolder.h

@@ -31,14 +31,18 @@ class StartPageTreeHolder  : public Component
 public:
     enum class Open { no, yes };
 
-    StartPageTreeHolder (const StringArray& headerNames, const std::vector<StringArray>& itemNames,
-                         std::function<void (int, int)>&& selectedCallback, Open shouldBeOpen)
+    StartPageTreeHolder (const String& title,
+                         const StringArray& headerNames,
+                         const std::vector<StringArray>& itemNames,
+                         std::function<void (int, int)>&& selectedCallback,
+                         Open shouldBeOpen)
         : headers (headerNames),
           items (itemNames),
           itemSelectedCallback (std::move (selectedCallback))
     {
         jassert (headers.size() == (int) items.size());
 
+        tree.setTitle (title);
         tree.setRootItem (new TreeRootItem (*this));
         tree.setRootItemVisible (false);
         tree.setIndentSize (15);
@@ -88,13 +92,14 @@ private:
                 addSubItem (new TreeSubItem (owner, s, {}));
         }
 
-        bool mightContainSubItems() override     { return isHeader; }
-        bool canBeSelected() const override      { return ! isHeader; }
+        bool mightContainSubItems() override    { return isHeader; }
+        bool canBeSelected() const override     { return ! isHeader; }
 
-        int getItemWidth() const override        { return -1; }
-        int getItemHeight() const override       { return 25; }
+        int getItemWidth() const override       { return -1; }
+        int getItemHeight() const override      { return 25; }
 
-        String getUniqueName() const override    { return name; }
+        String getUniqueName() const override   { return name; }
+        String getAccessibilityName() override  { return getUniqueName(); }
 
         void paintOpenCloseButton (Graphics& g, const Rectangle<float>& area, Colour, bool isMouseOver) override
         {
@@ -122,10 +127,13 @@ private:
             g.drawFittedText (name, bounds.reduced (5).withTrimmedLeft (10), Justification::centredLeft, 1);
         }
 
-        void itemClicked (const MouseEvent&) override
+        void itemClicked (const MouseEvent& e) override
         {
             if (isSelected())
                 itemSelectionChanged (true);
+
+            if (e.mods.isPopupMenu() && mightContainSubItems())
+                setOpen (! isOpen());
         }
 
         void itemSelectionChanged (bool isNowSelected) override

extras/Projucer/Source/Application/UserAccount/jucer_LoginFormComponent.h

@@ -35,16 +35,21 @@ public:
     LoginFormComponent (MainWindow& window)
         : mainWindow (window)
     {
+        setTitle ("Login");
+        setFocusContainerType (FocusContainerType::focusContainer);
+
         addAndMakeVisible (emailBox);
         emailBox.setTextToShowWhenEmpty ("Email", Colours::black.withAlpha (0.2f));
         emailBox.setJustification (Justification::centredLeft);
         emailBox.onReturnKey = [this] { submitDetails(); };
+        emailBox.setTitle ("Email");
 
         addAndMakeVisible (passwordBox);
         passwordBox.setTextToShowWhenEmpty ("Password", Colours::black.withAlpha (0.2f));
         passwordBox.setPasswordCharacter ((juce_wchar) 0x2022);
         passwordBox.setJustification (Justification::centredLeft);
         passwordBox.onReturnKey = [this] { submitDetails(); };
+        passwordBox.setTitle ("Password");
 
         addAndMakeVisible (logInButton);
         logInButton.onClick = [this] { submitDetails(); };
@@ -72,6 +77,7 @@ public:
         dismissButton.setShape (getLookAndFeel().getCrossShape (1.0f), false, true, false);
         addAndMakeVisible (dismissButton);
         dismissButton.onClick = [this] { mainWindow.hideLoginFormOverlay(); };
+        dismissButton.setTitle ("Dismiss");
 
         setWantsKeyboardFocus (true);
         setOpaque (true);

extras/Projucer/Source/Application/Windows/jucer_GlobalPathsWindowComponent.h

@@ -127,9 +127,9 @@ public:
 
         PropertyComponent* jucePathPropertyComponent = nullptr;
 
-        for (auto* prop : propertyGroup.properties)
+        for (const auto& prop : propertyGroup.getProperties())
             if (prop->getName() == "Path to JUCE")
-                jucePathPropertyComponent = prop;
+                jucePathPropertyComponent = prop.get();
 
         if (jucePathPropertyComponent != nullptr)
         {

extras/Projucer/Source/Application/jucer_MainWindow.cpp

@@ -487,6 +487,10 @@ void MainWindow::showLoginFormOverlay()
 {
     blurOverlayComponent = std::make_unique<BlurOverlayWithComponent> (*this, std::make_unique<LoginFormComponent> (*this));
     loginFormOpen = true;
+
+    if (auto* loginForm = blurOverlayComponent->getChildComponent (0))
+        if (auto* handler = loginForm->getAccessibilityHandler())
+            handler->grabFocus();
 }
 
 void MainWindow::hideLoginFormOverlay()