From 5d001564916ee7e6d33902874a6a4df1097a4bbe Mon Sep 17 00:00:00 2001 From: reuk Date: Mon, 8 Sep 2025 12:01:53 +0100 Subject: [PATCH] Remove unnecessary virtual keywords in final classes --- .../juce_audio_plugin_client_Standalone.cpp | 4 ++-- .../format_types/juce_VST3PluginFormat.cpp | 18 +++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/modules/juce_audio_plugin_client/juce_audio_plugin_client_Standalone.cpp b/modules/juce_audio_plugin_client/juce_audio_plugin_client_Standalone.cpp index 5bac735657..06b3d091a5 100644 --- a/modules/juce_audio_plugin_client/juce_audio_plugin_client_Standalone.cpp +++ b/modules/juce_audio_plugin_client/juce_audio_plugin_client_Standalone.cpp @@ -87,7 +87,7 @@ public: bool moreThanOneInstanceAllowed() override { return true; } void anotherInstanceStarted (const String&) override {} - virtual StandaloneFilterWindow* createWindow() + StandaloneFilterWindow* createWindow() { if (Desktop::getInstance().getDisplays().displays.isEmpty()) { @@ -101,7 +101,7 @@ public: createPluginHolder()); } - virtual std::unique_ptr createPluginHolder() + std::unique_ptr createPluginHolder() { constexpr auto autoOpenMidiDevices = #if (JUCE_ANDROID || JUCE_IOS) && ! JUCE_DONT_AUTO_OPEN_MIDI_DEVICES_ON_MOBILE diff --git a/modules/juce_audio_processors/format_types/juce_VST3PluginFormat.cpp b/modules/juce_audio_processors/format_types/juce_VST3PluginFormat.cpp index 8cba7db9fe..3444f06a44 100644 --- a/modules/juce_audio_processors/format_types/juce_VST3PluginFormat.cpp +++ b/modules/juce_audio_processors/format_types/juce_VST3PluginFormat.cpp @@ -608,8 +608,8 @@ struct VST3HostContext final : public Vst::IComponentHandler, // From VST V3.0. //============================================================================== struct ContextMenu final : public Vst::IContextMenu { - ContextMenu (VST3PluginInstance& pluginInstance) : owner (pluginInstance) {} - virtual ~ContextMenu() {} + explicit ContextMenu (VST3PluginInstance& pluginInstance) : owner (pluginInstance) {} + ~ContextMenu() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -915,7 +915,7 @@ private: { public: AttributeList() = default; - virtual ~AttributeList() = default; + ~AttributeList() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -1002,7 +1002,7 @@ private: struct Message final : public Vst::IMessage { Message() = default; - virtual ~Message() = default; + ~Message() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -2180,7 +2180,7 @@ public: { } - virtual ~HostToClientParamQueue() = default; + ~HostToClientParamQueue() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -2285,7 +2285,7 @@ public: { } - virtual ~ClientToHostParamQueue() = default; + ~ClientToHostParamQueue() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -2366,7 +2366,7 @@ class ParameterChanges final : public Vst::IParameterChanges using Queues = std::vector; public: - virtual ~ParameterChanges() = default; + ~ParameterChanges() = default; JUCE_DECLARE_VST3_COM_REF_METHODS JUCE_DECLARE_VST3_COM_QUERY_METHODS @@ -3108,8 +3108,8 @@ public: struct TrackPropertiesAttributeList final : public Vst::IAttributeList { - TrackPropertiesAttributeList (const TrackProperties& properties) : props (properties) {} - virtual ~TrackPropertiesAttributeList() {} + explicit TrackPropertiesAttributeList (const TrackProperties& properties) : props (properties) {} + ~TrackPropertiesAttributeList() = default; JUCE_DECLARE_VST3_COM_REF_METHODS