mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Windowing: Fix issue where edge resizers could incorrectly be displayed for non-resizable windows

Browse source 
The buggy behaviour could be seen in a blank GUI app project by setting
a native titlebar and calling setResizable (false, false). The resulting
window would still display a resize cursor when hovering the window
border.
This commit is contained in:
reuk 2024-11-25 18:29:35 +00:00
parent 4b9253dc76
commit 543ae06632
No known key found for this signature in database
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
modules/juce_gui_basics/native/juce_Windowing_windows.cpp
View file

@ -2390,6 +2390,7 @@ private:
const auto hasMax = (styleFlags & windowHasMaximiseButton) != 0;
const auto appearsOnTaskbar = (styleFlags & windowAppearsOnTaskbar) != 0;
const auto resizable = (styleFlags & windowIsResizable) != 0;
const auto usesDropShadow = windowUsesNativeShadow();
if (parentToAddTo != nullptr)
{
@ -2397,13 +2398,14 @@ private:
}
else
{
if (titled || windowUsesNativeShadow())
if (titled || usesDropShadow)
{
type |= usesDropShadow ? WS_CAPTION : 0;
type |= titled ? (WS_OVERLAPPED | WS_CAPTION) : WS_POPUP;
type |= hasClose ? (WS_SYSMENU | WS_CAPTION) : 0;
type |= hasMin ? (WS_MINIMIZEBOX | WS_CAPTION | WS_SYSMENU) : 0;
type |= hasMax ? (WS_MAXIMIZEBOX | WS_CAPTION | WS_SYSMENU) : 0;
type |= resizable || windowUsesNativeShadow() ? WS_THICKFRAME : 0;
type |= resizable ? WS_THICKFRAME : 0;
}
else
{
@ -2420,7 +2422,7 @@ private:
L"", type, 0, 0, 0, 0, parentToAddTo, nullptr,
(HINSTANCE) Process::getCurrentModuleInstanceHandle(), nullptr);
if (! titled && windowUsesNativeShadow())
if (! titled && usesDropShadow)
{
// The choice of margins is very particular.
// - Using 0 for all values disables the system decoration (shadow etc.) completely.