mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-02-06 04:00:08 +00:00
Code Activity

Fix for blank windows when closing VST windows on Cubase 7 or later.

Browse source
This commit is contained in:
jules 2015-03-24 16:08:46 +00:00
parent a4f5faec2d
commit 3bcc182fe9
2 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
modules/juce_audio_plugin_client/VST/juce_VST_Wrapper.mm
View file

@ -86,9 +86,18 @@ void* attachComponentToWindowRef (Component* comp, void* parentWindowOrView, boo
if (! isNSView)
{
NSWindow* hostWindow = [[NSWindow alloc] initWithWindowRef: parentWindowOrView];
[hostWindow retain];
if (getHostType().isCubase7orLater())
{
[hostWindow setReleasedWhenClosed: NO];
}
else
{
[hostWindow retain];
[hostWindow setReleasedWhenClosed: YES];
}
[hostWindow setCanHide: YES];
[hostWindow setReleasedWhenClosed: YES];
HIViewRef parentView = 0;
@ -202,7 +211,10 @@ void detachComponentFromWindowRef (Component* comp, void* window, bool isNSView)
comp->removeFromDesktop();
[pluginView release];
[hostWindow release];
if (getHostType().isCubase7orLater())
[hostWindow close];
else
[hostWindow release];
static bool needToRunMessageLoop = ! getHostType().isReaper();

7
modules/juce_audio_plugin_client/utility/juce_PluginHostType.h
View file

@ -57,6 +57,7 @@ public:
SteinbergCubase5Bridged,
SteinbergCubase6,
SteinbergCubase7,
SteinbergCubase8,
SteinbergCubaseGeneric,
SteinbergNuendo3,
SteinbergNuendo4,
@ -82,7 +83,8 @@ public:
bool isAdobeAudition() const noexcept { return type == AdobeAudition; }
bool isArdour() const noexcept { return type == Ardour; }
bool isDigitalPerformer() const noexcept { return type == DigitalPerformer; }
bool isCubase() const noexcept { return type == SteinbergCubase4 || type == SteinbergCubase5 || type == SteinbergCubase5Bridged || type == SteinbergCubase6 || type == SteinbergCubase7 || type == SteinbergCubaseGeneric; }
bool isCubase() const noexcept { return type == SteinbergCubase4 || type == SteinbergCubase5 || type == SteinbergCubase5Bridged || type == SteinbergCubase6 || type == SteinbergCubase7 || type == SteinbergCubase8 || type == SteinbergCubaseGeneric; }
bool isCubase7orLater() const noexcept { return isCubase() && ! (type == SteinbergCubase4 || type == SteinbergCubase5 || type == SteinbergCubase6); }
bool isCubaseBridged() const noexcept { return type == SteinbergCubase5Bridged; }
bool isLogic() const noexcept { return type == AppleLogic; }
bool isFruityLoops() const noexcept { return type == FruityLoops; }
@ -128,6 +130,7 @@ public:
case SteinbergCubase5Bridged: return "Steinberg Cubase 5 Bridged";
case SteinbergCubase6: return "Steinberg Cubase 6";
case SteinbergCubase7: return "Steinberg Cubase 7";
case SteinbergCubase8: return "Steinberg Cubase 8";
case SteinbergCubaseGeneric: return "Steinberg Cubase";
case SteinbergNuendo3: return "Steinberg Nuendo 3";
case SteinbergNuendo4: return "Steinberg Nuendo 4";
@ -179,6 +182,7 @@ private:
if (hostFilename.containsIgnoreCase ("Cubase 5")) return SteinbergCubase5;
if (hostFilename.containsIgnoreCase ("Cubase 6")) return SteinbergCubase6;
if (hostFilename.containsIgnoreCase ("Cubase 7")) return SteinbergCubase7;
if (hostFilename.containsIgnoreCase ("Cubase 8")) return SteinbergCubase8;
if (hostFilename.containsIgnoreCase ("Cubase")) return SteinbergCubaseGeneric;
if (hostPath.containsIgnoreCase ("Wavelab 7")) return SteinbergWavelab7;
if (hostPath.containsIgnoreCase ("Wavelab 8")) return SteinbergWavelab8;
@ -208,6 +212,7 @@ private:
if (hostFilename.containsIgnoreCase ("Cubase5")) return SteinbergCubase5;
if (hostFilename.containsIgnoreCase ("Cubase6")) return SteinbergCubase6;
if (hostFilename.containsIgnoreCase ("Cubase7")) return SteinbergCubase7;
if (hostFilename.containsIgnoreCase ("Cubase8")) return SteinbergCubase8;
if (hostFilename.containsIgnoreCase ("Cubase")) return SteinbergCubaseGeneric;
if (hostFilename.containsIgnoreCase ("VSTBridgeApp")) return SteinbergCubase5Bridged;
if (hostPath.containsIgnoreCase ("Wavelab 5")) return SteinbergWavelab5;