mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Android: Fix a couple of accessibility-related crashes

Browse source 
These crashes could be seen in the DemoRunner when selecting items in
nested PopupMenu windows.
This commit is contained in:
reuk 2022-05-23 19:59:57 +01:00
parent 61b26e4e35
commit 2b1745272e
No known key found for this signature in database
GPG key ID: 9ADCD339CFC98A11
5 changed files with 24 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
modules/juce_gui_basics/components/juce_Component.cpp
View file

@ -3308,6 +3308,18 @@ AccessibilityHandler* Component::getAccessibilityHandler()
|| accessibilityHandler->getTypeIndex() != std::type_index (typeid (*this)))
{
accessibilityHandler = createAccessibilityHandler();
// On Android, notifying that an element was created can cause the system to request
// the accessibility node info for the new element. If we're not careful, this will lead
// to recursive calls, as each time an element is created, new node info will be requested,
// causing an element to be created, causing a new info request...
// By assigning the accessibility handler before notifying the system that an element was
// created, the if() predicate above should evaluate to false on recursive calls,
// terminating the recursion.
if (accessibilityHandler != nullptr)
notifyAccessibilityEventInternal (*accessibilityHandler, InternalAccessibilityEvent::elementCreated);
else
jassertfalse; // createAccessibilityHandler must return non-null
}
return accessibilityHandler.get();