Warnings: Reformat and match projucer and cmake recommended warnings

extras/Build/CMake/JUCEHelperTargets.cmake

@@ -41,28 +41,63 @@ if((CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") OR (CMAKE_CXX_COMPILER_FRONTEND_VARIA
     target_compile_options(juce_recommended_warning_flags INTERFACE "/W4")
 elseif((CMAKE_CXX_COMPILER_ID STREQUAL "Clang") OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang"))
     target_compile_options(juce_recommended_warning_flags INTERFACE
-        -Wall -Wshadow-all -Wshorten-64-to-32 -Wstrict-aliasing
-        -Wuninitialized -Wunused-parameter -Wconversion -Wsign-compare
-        -Wint-conversion -Wconditional-uninitialized -Wconstant-conversion
-        -Wsign-conversion -Wbool-conversion -Wextra-semi -Wunreachable-code
-        -Wcast-align -Wshift-sign-overflow -Wmissing-prototypes
-        -Wnullable-to-nonnull-conversion -Wno-ignored-qualifiers -Wswitch-enum
-        -Wpedantic -Wdeprecated -Wfloat-equal
+        -Wall
+        -Wshadow-all
+        -Wshorten-64-to-32
+        -Wstrict-aliasing
+        -Wuninitialized
+        -Wunused-parameter
+        -Wconversion
+        -Wsign-compare
+        -Wint-conversion
+        -Wconditional-uninitialized
+        -Wconstant-conversion
+        -Wsign-conversion
+        -Wbool-conversion
+        -Wextra-semi
+        -Wunreachable-code
+        -Wcast-align
+        -Wshift-sign-overflow
+        -Wmissing-prototypes
+        -Wnullable-to-nonnull-conversion
+        -Wno-ignored-qualifiers
+        -Wswitch-enum
+        -Wpedantic
+        -Wdeprecated
+        -Wfloat-equal
         $<$<OR:$<COMPILE_LANGUAGE:CXX>,$<COMPILE_LANGUAGE:OBJCXX>>:
-            -Wzero-as-null-pointer-constant -Wunused-private-field
-            -Woverloaded-virtual -Wreorder
+            -Wzero-as-null-pointer-constant
+            -Wunused-private-field
+            -Woverloaded-virtual
+            -Wreorder
             -Winconsistent-missing-destructor-override>
         $<$<OR:$<COMPILE_LANGUAGE:OBJC>,$<COMPILE_LANGUAGE:OBJCXX>>:
-            -Wunguarded-availability -Wunguarded-availability-new>)
+            -Wunguarded-availability
+            -Wunguarded-availability-new>)
 elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     target_compile_options(juce_recommended_warning_flags INTERFACE
-        -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wuninitialized
-        -Wunused-parameter -Wsign-compare -Wsign-conversion -Wunreachable-code
-        -Wcast-align -Wno-implicit-fallthrough -Wno-maybe-uninitialized
-        -Wno-ignored-qualifiers -Wswitch-enum
-        -Wredundant-decls -Wno-strict-overflow -Wshadow -Wfloat-equal
+        -Wall
+        -Wextra
+        -Wpedantic
+        -Wstrict-aliasing
+        -Wuninitialized
+        -Wunused-parameter
+        -Wsign-compare
+        -Wsign-conversion
+        -Wunreachable-code
+        -Wcast-align
+        -Wno-implicit-fallthrough
+        -Wno-maybe-uninitialized
+        -Wno-ignored-qualifiers
+        -Wswitch-enum
+        -Wredundant-decls
+        -Wno-strict-overflow
+        -Wshadow
+        -Wfloat-equal
         $<$<COMPILE_LANGUAGE:CXX>:
-            -Woverloaded-virtual -Wreorder -Wzero-as-null-pointer-constant>)
+            -Woverloaded-virtual
+            -Wreorder
+            -Wzero-as-null-pointer-constant>)
 endif()
 
 # ==================================================================================================

extras/Projucer/Source/ProjectSaving/jucer_ProjectExporter.cpp

@@ -922,17 +922,35 @@ ProjectExporter::BuildConfiguration::BuildConfiguration (Project& p, const Value
      configLinkerFlagsValue        (config, Ids::extraLinkerFlags,         getUndoManager())
 {
     auto& llvmFlags = recommendedCompilerWarningFlags[CompilerNames::llvm] = BuildConfiguration::CompilerWarningFlags::getRecommendedForGCCAndLLVM();
-    llvmFlags.common.addArray ({ "-Wshorten-64-to-32", "-Wconversion", "-Wint-conversion",
-                                 "-Wconditional-uninitialized", "-Wconstant-conversion", "-Wbool-conversion",
-                                 "-Wextra-semi", "-Wshift-sign-overflow",
-                                 "-Wshadow-all", "-Wnullable-to-nonnull-conversion",
-                                 "-Wmissing-prototypes" });
-    llvmFlags.cpp.addArray ({ "-Wunused-private-field", "-Winconsistent-missing-destructor-override" });
-    llvmFlags.objc.addArray ({ "-Wunguarded-availability", "-Wunguarded-availability-new" });
+
+    llvmFlags.common.addArray ({ "-Wshadow-all",
+                                 "-Wshorten-64-to-32",
+                                 "-Wconversion",
+                                 "-Wint-conversion",
+                                 "-Wconditional-uninitialized",
+                                 "-Wconstant-conversion",
+                                 "-Wbool-conversion",
+                                 "-Wextra-semi",
+                                 "-Wshift-sign-overflow",
+                                 "-Wmissing-prototypes",
+                                 "-Wnullable-to-nonnull-conversion",
+                                 "-Wpedantic",
+                                 "-Wdeprecated" });
+
+    llvmFlags.cpp.addArray ({ "-Wunused-private-field",
+                              "-Winconsistent-missing-destructor-override" });
+
+    llvmFlags.objc.addArray ({ "-Wunguarded-availability",
+                               "-Wunguarded-availability-new" });
 
     auto& gccFlags = recommendedCompilerWarningFlags[CompilerNames::gcc] = BuildConfiguration::CompilerWarningFlags::getRecommendedForGCCAndLLVM();
-    gccFlags.common.addArray ({ "-Wextra", "-Wsign-compare", "-Wno-implicit-fallthrough", "-Wno-maybe-uninitialized",
-                                "-Wredundant-decls", "-Wno-strict-overflow", "-Wshadow" });
+    gccFlags.common.addArray ({ "-Wextra",
+                                "-Wsign-compare",
+                                "-Wno-implicit-fallthrough",
+                                "-Wno-maybe-uninitialized",
+                                "-Wredundant-decls",
+                                "-Wno-strict-overflow",
+                                "-Wshadow" });
 }
 
 String ProjectExporter::BuildConfiguration::getGCCOptimisationFlag() const

modules/juce_audio_plugin_client/juce_audio_plugin_client_AAX.cpp

@@ -45,7 +45,9 @@ JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-Wdeprecated-declarations",
                                      "-Wshift-sign-overflow",
                                      "-Wsign-conversion",
                                      "-Wtautological-overlap-compare",
-                                     "-Wzero-as-null-pointer-constant")
+                                     "-Wzero-as-null-pointer-constant",
+                                     "-Wdeprecated-copy-with-user-provided-dtor",
+                                     "-Wdeprecated")
 
 #include <AAX_Version.h>
 

modules/juce_audio_plugin_client/juce_audio_plugin_client_AAX_utils.cpp

@@ -46,7 +46,10 @@ JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-Wdeprecated-declarations",
                                      "-Winconsistent-missing-destructor-override",
                                      "-Wshift-sign-overflow",
                                      "-Wunused-parameter",
-                                     "-Wzero-as-null-pointer-constant")
+                                     "-Wzero-as-null-pointer-constant",
+                                     "-Wfour-char-constants",
+                                     "-Wdeprecated-copy-with-user-provided-dtor",
+                                     "-Wdeprecated")
 JUCE_BEGIN_IGNORE_WARNINGS_MSVC (6001 6053 4996 5033 4068 4996)
 
 #include <Libs/AAXLibrary/source/AAX_CChunkDataParser.cpp>