mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

Global: Avoid floating-point equality checks where possible

Browse source
This commit is contained in:
reuk 2023-03-23 12:02:38 +00:00
parent 081b1ff216
commit 28414a6af8
No known key found for this signature in database
GPG key ID: FCB43929F012EE5C
150 changed files with 762 additions and 672 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/juce_dsp/processors/juce_DelayLine.h
View file

@ -271,7 +271,7 @@ private:
auto value1 = bufferData.getSample (channel, index1);
auto value2 = bufferData.getSample (channel, index2);
auto output = delayFrac == 0 ? value1 : value2 + alpha * (value1 - v[(size_t) channel]);
auto output = approximatelyEqual (delayFrac, (SampleType) 0) ? value1 : value2 + alpha * (value1 - v[(size_t) channel]);
v[(size_t) channel] = output;
return output;

5
modules/juce_dsp/processors/juce_IIRFilter_Impl.h
View file

@ -39,8 +39,9 @@ Coefficients<NumericType>& Coefficients<NumericType>::assignImpl (const NumericT
static_assert (Num % 2 == 0, "Must supply an even number of coefficients");
const auto a0Index = Num / 2;
const auto a0 = values[a0Index];
const auto a0Inv = a0 != NumericType() ? static_cast<NumericType> (1) / values[a0Index]
: NumericType();
const auto a0Inv = ! approximatelyEqual (a0, NumericType())
? static_cast<NumericType> (1) / values[a0Index]
: NumericType();
coefficients.clearQuick();
coefficients.ensureStorageAllocated ((int) jmax ((size_t) 8, Num));

2
modules/juce_dsp/processors/juce_Oversampling.cpp
View file

@ -755,7 +755,7 @@ void Oversampling<SampleType>::updateDelayLine()
auto latency = getUncompensatedLatency();
fractionalDelay = static_cast<SampleType> (1.0) - (latency - std::floor (latency));
if (fractionalDelay == static_cast<SampleType> (1.0))
if (approximatelyEqual (fractionalDelay, static_cast<SampleType> (1.0)))
fractionalDelay = static_cast<SampleType> (0.0);
else if (fractionalDelay < static_cast<SampleType> (0.618))
fractionalDelay += static_cast<SampleType> (1.0);

9
modules/juce_dsp/processors/juce_ProcessContext.h
View file

@ -48,9 +48,12 @@ struct ProcessSpec
constexpr bool operator== (const ProcessSpec& a, const ProcessSpec& b)
{
return a.sampleRate == b.sampleRate
&& a.maximumBlockSize == b.maximumBlockSize
&& a.numChannels == b.numChannels;
const auto tie = [] (const ProcessSpec& p)
{
return std::tie (p.sampleRate, p.maximumBlockSize, p.numChannels);
};
return tie (a) == tie (b);
}
constexpr bool operator!= (const ProcessSpec& a, const ProcessSpec& b) { return ! (a == b); }

2
modules/juce_dsp/processors/juce_ProcessorChain_test.cpp
View file

@ -39,7 +39,7 @@ class ProcessorChainTest : public UnitTest
template <typename Context>
void process (const Context& context) noexcept
{
bufferWasClear = context.getInputBlock().getSample (0, 0) == 0;
bufferWasClear = approximatelyEqual (context.getInputBlock().getSample (0, 0), 0.0f);
if (! context.isBypassed)
context.getOutputBlock().add (AddValue);