From 234525aef990d1d76cc2919619d819013350b5e4 Mon Sep 17 00:00:00 2001 From: jules Date: Thu, 27 Dec 2012 19:56:18 +0000 Subject: [PATCH] Increased the warning level in a couple of OSX builds, and removed some pedantic warnings in the introjucer. --- .../The Introjucer.xcodeproj/project.pbxproj | 2 ++ extras/Introjucer/Introjucer.jucer | 2 +- .../Application/jucer_AppearanceSettings.cpp | 19 ++++++++++++------- .../Source/Application/jucer_JuceUpdater.cpp | 8 +++----- .../Source/Application/jucer_MainWindow.cpp | 2 +- .../Application/jucer_OpenDocumentManager.cpp | 6 +++--- .../Code Editor/jucer_SourceCodeEditor.h | 2 +- .../Project Saving/jucer_ProjectExporter.cpp | 12 ++++++------ .../Project Saving/jucer_ProjectExporter.h | 6 +++--- .../Source/Project/jucer_AudioPluginModule.h | 7 ++++--- .../Source/Project/jucer_ConfigPage.cpp | 12 ++++++------ .../Project/jucer_GroupInformationComponent.h | 4 ++-- .../Source/Project/jucer_Module.cpp | 8 ++++---- .../Source/Project/jucer_ModulesPanel.h | 2 +- .../Source/Project/jucer_NewProjectWizard.cpp | 4 ++-- .../Source/Project/jucer_Project.cpp | 2 +- .../Project/jucer_ProjectContentComponent.cpp | 2 +- .../Project/jucer_ProjectTreeViewBase.cpp | 14 +++++++------- .../Source/Project/jucer_ProjectType.cpp | 2 +- .../Source/Project/jucer_TreeViewTypes.cpp | 2 +- .../Source/Project/jucer_TreeViewTypes.h | 6 +++--- .../Utility/jucer_JucerTreeViewBase.cpp | 6 +++--- .../Juce Demo.xcodeproj/project.pbxproj | 2 ++ extras/JuceDemo/Juce Demo.jucer | 3 ++- .../RTAS/juce_RTAS_Wrapper.cpp | 3 +++ .../native/juce_mac_CoreGraphicsContext.mm | 2 +- .../native/juce_mac_MainMenu.mm | 2 +- .../native/juce_mac_NSViewComponentPeer.mm | 2 +- .../native/juce_mac_Windowing.mm | 4 ++-- .../widgets/juce_TableListBox.cpp | 16 ++++++++-------- 30 files changed, 88 insertions(+), 76 deletions(-) diff --git a/extras/Introjucer/Builds/MacOSX/The Introjucer.xcodeproj/project.pbxproj b/extras/Introjucer/Builds/MacOSX/The Introjucer.xcodeproj/project.pbxproj index 429bbb527a..b12ed892c3 100644 --- a/extras/Introjucer/Builds/MacOSX/The Introjucer.xcodeproj/project.pbxproj +++ b/extras/Introjucer/Builds/MacOSX/The Introjucer.xcodeproj/project.pbxproj @@ -1645,6 +1645,7 @@ HEADER_SEARCH_PATHS = "../../JuceLibraryCode $(inherited)"; GCC_OPTIMIZATION_LEVEL = 0; INFOPLIST_FILE = Info.plist; + OTHER_CPLUSPLUSFLAGS = "-W -Wall -Wshadow -Wno-missing-field-initializers -Wno-strict-aliasing"; INSTALL_PATH = "$(HOME)/Applications"; MACOSX_DEPLOYMENT_TARGET_ppc = 10.4; SDKROOT_ppc = macosx10.5; @@ -1663,6 +1664,7 @@ HEADER_SEARCH_PATHS = "../../JuceLibraryCode $(inherited)"; GCC_OPTIMIZATION_LEVEL = 3; INFOPLIST_FILE = Info.plist; + OTHER_CPLUSPLUSFLAGS = "-W -Wall -Wshadow -Wno-missing-field-initializers -Wno-strict-aliasing"; INSTALL_PATH = "$(HOME)/Applications"; MACOSX_DEPLOYMENT_TARGET = 10.5; MACOSX_DEPLOYMENT_TARGET_ppc = 10.4; diff --git a/extras/Introjucer/Introjucer.jucer b/extras/Introjucer/Introjucer.jucer index 0958d700c7..8dcc1ad368 100644 --- a/extras/Introjucer/Introjucer.jucer +++ b/extras/Introjucer/Introjucer.jucer @@ -15,7 +15,7 @@ + bigIcon="rVgowdy" extraCompilerFlags="-W -Wall -Wshadow -Wno-missing-field-initializers -Wno-strict-aliasing"> diff --git a/extras/Introjucer/Source/Application/jucer_AppearanceSettings.cpp b/extras/Introjucer/Source/Application/jucer_AppearanceSettings.cpp index 8b04cace35..1f5030f4f9 100644 --- a/extras/Introjucer/Source/Application/jucer_AppearanceSettings.cpp +++ b/extras/Introjucer/Source/Application/jucer_AppearanceSettings.cpp @@ -48,6 +48,11 @@ namespace AppearanceColours { "Selected Text Bkgd", CodeEditorComponent::highlightColourId, false, false }, { "Caret", CaretComponent::caretColourId, false, true } }; + + enum + { + numColours = sizeof (AppearanceColours::colours) / sizeof (AppearanceColours::colours[0]) + }; } //============================================================================== @@ -56,7 +61,7 @@ AppearanceSettings::AppearanceSettings (bool updateAppWhenChanged) { IntrojucerLookAndFeel lf; - for (int i = 0; i < sizeof (AppearanceColours::colours) / sizeof (AppearanceColours::colours[0]); ++i) + for (int i = 0; i < AppearanceColours::numColours; ++i) getColourValue (AppearanceColours::colours[i].name) = lf.findColour (AppearanceColours::colours[i].colourID).toString(); CodeDocument doc; @@ -192,7 +197,7 @@ void AppearanceSettings::updateColourScheme() void AppearanceSettings::applyToLookAndFeel (LookAndFeel& lf) const { - for (int i = 0; i < sizeof (AppearanceColours::colours) / sizeof (AppearanceColours::colours[0]); ++i) + for (int i = 0; i < AppearanceColours::numColours; ++i) { Colour col; if (getColour (AppearanceColours::colours[i].name, col)) @@ -222,7 +227,7 @@ void AppearanceSettings::applyToCodeEditor (CodeEditorComponent& editor) const editor.setColourScheme (cs); editor.setFont (getCodeFont()); - for (int i = 0; i < sizeof (AppearanceColours::colours) / sizeof (AppearanceColours::colours[0]); ++i) + for (int i = 0; i < AppearanceColours::numColours; ++i) { if (AppearanceColours::colours[i].applyToEditorOnly) { @@ -547,9 +552,9 @@ Rectangle IntrojucerLookAndFeel::getPropertyComponentContentPosition (Prope return LookAndFeel::getPropertyComponentContentPosition (component); } -int IntrojucerLookAndFeel::getTabButtonOverlap (int tabDepth) { return -1; } +int IntrojucerLookAndFeel::getTabButtonOverlap (int /*tabDepth*/) { return -1; } int IntrojucerLookAndFeel::getTabButtonSpaceAroundImage() { return 1; } -int IntrojucerLookAndFeel::getTabButtonBestWidth (TabBarButton& button, int tabDepth) { return 120; } +int IntrojucerLookAndFeel::getTabButtonBestWidth (TabBarButton&, int /*tabDepth*/) { return 120; } void IntrojucerLookAndFeel::createTabTextLayout (const TabBarButton& button, const Rectangle& textArea, GlyphArrangement& textLayout) { @@ -700,8 +705,8 @@ void IntrojucerLookAndFeel::fillWithBackgroundTexture (Component& c, Graphics& g } void IntrojucerLookAndFeel::drawConcertinaPanelHeader (Graphics& g, const Rectangle& area, - bool isMouseOver, bool isMouseDown, - ConcertinaPanel& concertina, Component& panel) + bool isMouseOver, bool /*isMouseDown*/, + ConcertinaPanel&, Component& panel) { const Colour bkg (findColour (mainBackgroundColourId)); diff --git a/extras/Introjucer/Source/Application/jucer_JuceUpdater.cpp b/extras/Introjucer/Source/Application/jucer_JuceUpdater.cpp index 808f5d55a4..4b522d95c5 100644 --- a/extras/Introjucer/Source/Application/jucer_JuceUpdater.cpp +++ b/extras/Introjucer/Source/Application/jucer_JuceUpdater.cpp @@ -246,13 +246,13 @@ int JuceUpdater::getNumRows() return latestList.modules.size(); } -void JuceUpdater::paintListBoxItem (int rowNumber, Graphics& g, int width, int height, bool rowIsSelected) +void JuceUpdater::paintListBoxItem (int /*rowNumber*/, Graphics& g, int /*width*/, int /*height*/, bool rowIsSelected) { if (rowIsSelected) g.fillAll (findColour (TextEditor::highlightColourId)); } -Component* JuceUpdater::refreshComponentForRow (int rowNumber, bool isRowSelected, Component* existingComponentToUpdate) +Component* JuceUpdater::refreshComponentForRow (int rowNumber, bool /*isRowSelected*/, Component* existingComponentToUpdate) { class UpdateListComponent : public Component { @@ -327,9 +327,7 @@ Component* JuceUpdater::refreshComponentForRow (int rowNumber, bool isRowSelecte if (c == nullptr) c = new UpdateListComponent (*this); - ModuleList::Module* m = latestList.modules [rowNumber]; - - if (m != nullptr) + if (ModuleList::Module* m = latestList.modules [rowNumber]) c->setModule (m, moduleList.findModuleInfo (m->uid), versionsToDownload.getPropertyAsValue (m->uid, nullptr)); diff --git a/extras/Introjucer/Source/Application/jucer_MainWindow.cpp b/extras/Introjucer/Source/Application/jucer_MainWindow.cpp index f3675fa682..7215b005ad 100644 --- a/extras/Introjucer/Source/Application/jucer_MainWindow.cpp +++ b/extras/Introjucer/Source/Application/jucer_MainWindow.cpp @@ -218,7 +218,7 @@ bool MainWindow::isInterestedInFileDrag (const StringArray& filenames) return false; } -void MainWindow::filesDropped (const StringArray& filenames, int mouseX, int mouseY) +void MainWindow::filesDropped (const StringArray& filenames, int /*mouseX*/, int /*mouseY*/) { for (int i = filenames.size(); --i >= 0;) { diff --git a/extras/Introjucer/Source/Application/jucer_OpenDocumentManager.cpp b/extras/Introjucer/Source/Application/jucer_OpenDocumentManager.cpp index e8c054b633..bffeff1538 100644 --- a/extras/Introjucer/Source/Application/jucer_OpenDocumentManager.cpp +++ b/extras/Introjucer/Source/Application/jucer_OpenDocumentManager.cpp @@ -42,8 +42,8 @@ public: //============================================================================== struct Type : public OpenDocumentManager::DocumentType { - bool canOpenFile (const File&) { return true; } - Document* openFile (Project* project, const File& file) { return new UnknownDocument (project, file); } + bool canOpenFile (const File&) { return true; } + Document* openFile (Project* p, const File& f) { return new UnknownDocument (p, f); } }; //============================================================================== @@ -62,7 +62,7 @@ public: Component* createViewer() { return createEditor(); } void fileHasBeenRenamed (const File& newFile) { file = newFile; } String getState() const { return String::empty; } - void restoreState (const String& state) {} + void restoreState (const String&) {} String getType() const { diff --git a/extras/Introjucer/Source/Code Editor/jucer_SourceCodeEditor.h b/extras/Introjucer/Source/Code Editor/jucer_SourceCodeEditor.h index 9f05e77a05..10f33b5cf6 100644 --- a/extras/Introjucer/Source/Code Editor/jucer_SourceCodeEditor.h +++ b/extras/Introjucer/Source/Code Editor/jucer_SourceCodeEditor.h @@ -119,7 +119,7 @@ public: return true; } - Document* openFile (Project* project, const File& file) { return new SourceCodeDocument (project, file); } + Document* openFile (Project* p, const File& file) { return new SourceCodeDocument (p, file); } }; protected: diff --git a/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.cpp b/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.cpp index 896f7cf004..17f8f5ae58 100644 --- a/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.cpp +++ b/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.cpp @@ -333,19 +333,19 @@ ProjectExporter::BuildConfiguration::Ptr ProjectExporter::getConfiguration (int return createBuildConfig (getConfigurations().getChild (index)); } -bool ProjectExporter::hasConfigurationNamed (const String& name) const +bool ProjectExporter::hasConfigurationNamed (const String& nameToFind) const { const ValueTree configs (getConfigurations()); for (int i = configs.getNumChildren(); --i >= 0;) - if (configs.getChild(i) [Ids::name].toString() == name) + if (configs.getChild(i) [Ids::name].toString() == nameToFind) return true; return false; } -String ProjectExporter::getUniqueConfigName (String name) const +String ProjectExporter::getUniqueConfigName (String nm) const { - String nameRoot (name); + String nameRoot (nm); while (CharacterFunctions::isDigit (nameRoot.getLastCharacter())) nameRoot = nameRoot.dropLastCharacters (1); @@ -353,9 +353,9 @@ String ProjectExporter::getUniqueConfigName (String name) const int suffix = 2; while (hasConfigurationNamed (name)) - name = nameRoot + " " + String (suffix++); + nm = nameRoot + " " + String (suffix++); - return name; + return nm; } void ProjectExporter::addNewConfiguration (const BuildConfiguration* configToCopy) diff --git a/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.h b/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.h index cf8ab5f35c..25c5995546 100644 --- a/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.h +++ b/extras/Introjucer/Source/Project Saving/jucer_ProjectExporter.h @@ -69,8 +69,8 @@ public: Project& getProject() noexcept { return project; } const Project& getProject() const noexcept { return project; } - Value getSetting (const Identifier& name) { return settings.getPropertyAsValue (name, project.getUndoManagerFor (settings)); } - String getSettingString (const Identifier& name) const { return settings [name]; } + Value getSetting (const Identifier& nm) { return settings.getPropertyAsValue (nm, project.getUndoManagerFor (settings)); } + String getSettingString (const Identifier& nm) const { return settings [nm]; } Value getJuceFolderValue() { return getSetting (Ids::juceFolder); } String getJuceFolderString() const { return getSettingString (Ids::juceFolder); } @@ -200,7 +200,7 @@ public: Value getUserNotes() { return getValue (Ids::userNotes); } - Value getValue (const Identifier& name) { return config.getPropertyAsValue (name, getUndoManager()); } + Value getValue (const Identifier& nm) { return config.getPropertyAsValue (nm, getUndoManager()); } UndoManager* getUndoManager() const { return project.getUndoManagerFor (config); } void createPropertyEditors (PropertyListBuilder&); diff --git a/extras/Introjucer/Source/Project/jucer_AudioPluginModule.h b/extras/Introjucer/Source/Project/jucer_AudioPluginModule.h index 04ede4a81f..3381d4ed4e 100644 --- a/extras/Introjucer/Source/Project/jucer_AudioPluginModule.h +++ b/extras/Introjucer/Source/Project/jucer_AudioPluginModule.h @@ -345,7 +345,7 @@ namespace RTASHelpers } } - static inline void prepareExporter (ProjectExporter& exporter, ProjectSaver& projectSaver, const File& moduleFolder) + static inline void prepareExporter (ProjectExporter& exporter, ProjectSaver& projectSaver, const File& /*moduleFolder*/) { if (isExporterSupported (exporter)) { @@ -370,7 +370,8 @@ namespace RTASHelpers String msvcPathToRTASFolder (juceFolder.getChildFile ("juce_audio_plugin_client/RTAS") .toWindowsStyle() + "\\"); - exporter.msvcDelayLoadedDLLs = "DAE.dll; DigiExt.dll; DSI.dll; PluginLib.dll; DSPManager.dll"; + exporter.msvcDelayLoadedDLLs = "DAE.dll; DigiExt.dll; DSI.dll; PluginLib.dll; " + "DSPManager.dll; DSPManager.dll; DSPManagerClientLib.dll; RTASClientLib.dll"; if (! exporter.getExtraLinkerFlagsString().contains ("/FORCE:multiple")) exporter.getExtraLinkerFlags() = exporter.getExtraLinkerFlags().toString() + " /FORCE:multiple"; @@ -528,7 +529,7 @@ namespace AAXHelpers exporter.addToExtraSearchPaths (aaxFolder.getChildFile ("Interfaces").getChildFile ("ACF")); } - static inline void prepareExporter (ProjectExporter& exporter, ProjectSaver& projectSaver, const File& moduleFolder) + static inline void prepareExporter (ProjectExporter& exporter, ProjectSaver& projectSaver, const File& /*moduleFolder*/) { if (isExporterSupported (exporter)) { diff --git a/extras/Introjucer/Source/Project/jucer_ConfigPage.cpp b/extras/Introjucer/Source/Project/jucer_ConfigPage.cpp index 44df9fb8fa..6d6d6a02e7 100644 --- a/extras/Introjucer/Source/Project/jucer_ConfigPage.cpp +++ b/extras/Introjucer/Source/Project/jucer_ConfigPage.cpp @@ -130,14 +130,14 @@ namespace ProjectSettingsTreeClasses class SettingsComp : public Component { public: - SettingsComp (ProjectExporter::BuildConfiguration* config, const String& exporterName) + SettingsComp (ProjectExporter::BuildConfiguration* conf, const String& expName) { addAndMakeVisible (&group); PropertyListBuilder props; - config->createPropertyEditors (props); + conf->createPropertyEditors (props); group.setProperties (props); - group.setName (exporterName + " / " + config->getName()); + group.setName (expName + " / " + conf->getName()); parentSizeChanged(); } @@ -258,14 +258,14 @@ namespace ProjectSettingsTreeClasses class SettingsComp : public Component { public: - SettingsComp (ProjectExporter* exporter) + SettingsComp (ProjectExporter* exp) { addAndMakeVisible (&group); PropertyListBuilder props; - exporter->createPropertyEditors (props); + exp->createPropertyEditors (props); group.setProperties (props); - group.setName ("Export target: " + exporter->getName()); + group.setName ("Export target: " + exp->getName()); parentSizeChanged(); } diff --git a/extras/Introjucer/Source/Project/jucer_GroupInformationComponent.h b/extras/Introjucer/Source/Project/jucer_GroupInformationComponent.h index a9ce81781d..90b60387c6 100644 --- a/extras/Introjucer/Source/Project/jucer_GroupInformationComponent.h +++ b/extras/Introjucer/Source/Project/jucer_GroupInformationComponent.h @@ -69,13 +69,13 @@ public: return item.getNumChildren(); } - void paintListBoxItem (int rowNumber, Graphics& g, int width, int height, bool rowIsSelected) + void paintListBoxItem (int /*rowNumber*/, Graphics& g, int width, int height, bool /*rowIsSelected*/) { g.setColour (Colours::white.withAlpha (0.4f)); g.fillRect (0, 0, width, height - 1); } - Component* refreshComponentForRow (int rowNumber, bool isRowSelected, Component* existingComponentToUpdate) + Component* refreshComponentForRow (int rowNumber, bool /*isRowSelected*/, Component* existingComponentToUpdate) { if (rowNumber < getNumRows()) { diff --git a/extras/Introjucer/Source/Project/jucer_Module.cpp b/extras/Introjucer/Source/Project/jucer_Module.cpp index a702ad4f2b..cccfe55383 100644 --- a/extras/Introjucer/Source/Project/jucer_Module.cpp +++ b/extras/Introjucer/Source/Project/jucer_Module.cpp @@ -313,7 +313,7 @@ void ModuleList::getDependencies (const String& moduleID, StringArray& dependenc } } -void ModuleList::createDependencies (const String& moduleID, OwnedArray& modules) const +void ModuleList::createDependencies (const String& moduleID, OwnedArray&) const { ScopedPointer m (loadModule (moduleID)); @@ -592,10 +592,10 @@ static bool exporterTargetMatches (const String& test, String target) for (int i = validTargets.size(); --i >= 0;) { - const String& target = validTargets[i]; + const String& targetName = validTargets[i]; - if (target == test - || (target.startsWithChar ('!') && test != target.substring (1).trimStart())) + if (targetName == test + || (targetName.startsWithChar ('!') && test != targetName.substring (1).trimStart())) return true; } diff --git a/extras/Introjucer/Source/Project/jucer_ModulesPanel.h b/extras/Introjucer/Source/Project/jucer_ModulesPanel.h index 4bb0275b0e..da81b73f2e 100644 --- a/extras/Introjucer/Source/Project/jucer_ModulesPanel.h +++ b/extras/Introjucer/Source/Project/jucer_ModulesPanel.h @@ -193,7 +193,7 @@ public: flipRow (row); } - void listBoxItemDoubleClicked (int row, const MouseEvent& e) + void listBoxItemDoubleClicked (int row, const MouseEvent&) { flipRow (row); } diff --git a/extras/Introjucer/Source/Project/jucer_NewProjectWizard.cpp b/extras/Introjucer/Source/Project/jucer_NewProjectWizard.cpp index f9513bb1ba..0fc7e10437 100644 --- a/extras/Introjucer/Source/Project/jucer_NewProjectWizard.cpp +++ b/extras/Introjucer/Source/Project/jucer_NewProjectWizard.cpp @@ -235,11 +235,11 @@ public: String getName() { return "Audio Plug-In"; } String getDescription() { return "Creates an audio plugin project"; } - void addSetupItems (Component& setupComp, OwnedArray& itemsCreated) + void addSetupItems (Component&, OwnedArray& /*itemsCreated*/) { } - Result processResultsFromSetupItems (Component& setupComp) + Result processResultsFromSetupItems (Component&) { return Result::ok(); } diff --git a/extras/Introjucer/Source/Project/jucer_Project.cpp b/extras/Introjucer/Source/Project/jucer_Project.cpp index 392bbb4665..291a9df0f4 100644 --- a/extras/Introjucer/Source/Project/jucer_Project.cpp +++ b/extras/Introjucer/Source/Project/jucer_Project.cpp @@ -277,7 +277,7 @@ File Project::getLastDocumentOpened() { return lastDocumentOpe void Project::setLastDocumentOpened (const File& file) { lastDocumentOpened = file; } //============================================================================== -void Project::valueTreePropertyChanged (ValueTree& tree, const Identifier& property) +void Project::valueTreePropertyChanged (ValueTree&, const Identifier& property) { if (property == Ids::projectType) setMissingDefaultValues(); diff --git a/extras/Introjucer/Source/Project/jucer_ProjectContentComponent.cpp b/extras/Introjucer/Source/Project/jucer_ProjectContentComponent.cpp index d1e34c3816..32aafd16a3 100644 --- a/extras/Introjucer/Source/Project/jucer_ProjectContentComponent.cpp +++ b/extras/Introjucer/Source/Project/jucer_ProjectContentComponent.cpp @@ -647,7 +647,7 @@ void ProjectContentComponent::getCommandInfo (const CommandID commandID, Applica } } -bool ProjectContentComponent::isCommandActive (const CommandID commandID) +bool ProjectContentComponent::isCommandActive (const CommandID) { return project != nullptr; } diff --git a/extras/Introjucer/Source/Project/jucer_ProjectTreeViewBase.cpp b/extras/Introjucer/Source/Project/jucer_ProjectTreeViewBase.cpp index 352fe68595..3ea38480ea 100644 --- a/extras/Introjucer/Source/Project/jucer_ProjectTreeViewBase.cpp +++ b/extras/Introjucer/Source/Project/jucer_ProjectTreeViewBase.cpp @@ -81,7 +81,7 @@ void ProjectTreeViewBase::addFiles (const StringArray& files, int insertIndex) p->addFiles (files, insertIndex); } -void ProjectTreeViewBase::moveSelectedItemsTo (OwnedArray & selectedNodes, int insertIndex) +void ProjectTreeViewBase::moveSelectedItemsTo (OwnedArray &, int /*insertIndex*/) { jassertfalse; } @@ -116,8 +116,8 @@ void ProjectTreeViewBase::triggerAsyncRename (const Project::Item& itemToRename) class RenameMessage : public CallbackMessage { public: - RenameMessage (TreeView* const t, const Project::Item& item) - : tree (t), itemToRename (item) {} + RenameMessage (TreeView* const t, const Project::Item& i) + : tree (t), itemToRename (i) {} void messageCallback() { @@ -357,18 +357,18 @@ void ProjectTreeViewBase::treeChildrenChanged (const ValueTree& parentTree) } } -void ProjectTreeViewBase::valueTreePropertyChanged (ValueTree& tree, const Identifier& property) +void ProjectTreeViewBase::valueTreePropertyChanged (ValueTree& tree, const Identifier&) { if (tree == item.state) repaintItem(); } -void ProjectTreeViewBase::valueTreeChildAdded (ValueTree& parentTree, ValueTree& childWhichHasBeenAdded) +void ProjectTreeViewBase::valueTreeChildAdded (ValueTree& parentTree, ValueTree&) { treeChildrenChanged (parentTree); } -void ProjectTreeViewBase::valueTreeChildRemoved (ValueTree& parentTree, ValueTree& childWhichHasBeenRemoved) +void ProjectTreeViewBase::valueTreeChildRemoved (ValueTree& parentTree, ValueTree&) { treeChildrenChanged (parentTree); } @@ -378,7 +378,7 @@ void ProjectTreeViewBase::valueTreeChildOrderChanged (ValueTree& parentTree) treeChildrenChanged (parentTree); } -void ProjectTreeViewBase::valueTreeParentChanged (ValueTree& tree) +void ProjectTreeViewBase::valueTreeParentChanged (ValueTree&) { } diff --git a/extras/Introjucer/Source/Project/jucer_ProjectType.cpp b/extras/Introjucer/Source/Project/jucer_ProjectType.cpp index 32b128964f..d182f23a67 100644 --- a/extras/Introjucer/Source/Project/jucer_ProjectType.cpp +++ b/extras/Introjucer/Source/Project/jucer_ProjectType.cpp @@ -104,7 +104,7 @@ public: { } - void createPropertyEditors (Project& project, PropertyListBuilder& props) const + void createPropertyEditors (Project&, PropertyListBuilder&) const { } diff --git a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp index f6d80cf97d..65be2681aa 100644 --- a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp +++ b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.cpp @@ -218,7 +218,7 @@ void SourceFileTreeViewItem::setName (const String& newName) } } -ProjectTreeViewBase* SourceFileTreeViewItem::createSubItem (const Project::Item& child) +ProjectTreeViewBase* SourceFileTreeViewItem::createSubItem (const Project::Item&) { jassertfalse return nullptr; diff --git a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.h b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.h index c9914a4621..023089d273 100644 --- a/extras/Introjucer/Source/Project/jucer_TreeViewTypes.h +++ b/extras/Introjucer/Source/Project/jucer_TreeViewTypes.h @@ -36,8 +36,8 @@ public: SourceFileTreeViewItem (const Project::Item& item); ~SourceFileTreeViewItem(); - bool acceptsFileDrop (const StringArray& files) const { return false; } - bool acceptsDragItems (const OwnedArray & selectedNodes) { return false; } + bool acceptsFileDrop (const StringArray&) const { return false; } + bool acceptsDragItems (const OwnedArray &) { return false; } ProjectTreeViewBase* createSubItem (const Project::Item& child); void showDocument(); void showPopupMenu(); @@ -54,7 +54,7 @@ public: ~GroupTreeViewItem(); bool isRoot() const { return item.isMainGroup(); } - bool acceptsFileDrop (const StringArray& files) const { return true; } + bool acceptsFileDrop (const StringArray&) const { return true; } bool acceptsDragItems (const OwnedArray & selectedNodes); void checkFileStatus(); void moveSelectedItemsTo (OwnedArray & selectedNodes, int insertIndex); diff --git a/extras/Introjucer/Source/Utility/jucer_JucerTreeViewBase.cpp b/extras/Introjucer/Source/Utility/jucer_JucerTreeViewBase.cpp index 9e6c5cbc72..6a64bde4de 100644 --- a/extras/Introjucer/Source/Utility/jucer_JucerTreeViewBase.cpp +++ b/extras/Introjucer/Source/Utility/jucer_JucerTreeViewBase.cpp @@ -85,7 +85,7 @@ Font JucerTreeViewBase::getFont() const return Font (getItemHeight() * 0.6f); } -void JucerTreeViewBase::paintItem (Graphics& g, int width, int height) +void JucerTreeViewBase::paintItem (Graphics& g, int /*width*/, int /*height*/) { if (isSelected()) g.fillAll (getOwnerView()->findColour (treeviewHighlightColourId)); @@ -96,7 +96,7 @@ float JucerTreeViewBase::getIconSize() const return jmin (getItemHeight() - 4.0f, 18.0f); } -void JucerTreeViewBase::paintOpenCloseButton (Graphics& g, int width, int height, bool isMouseOver) +void JucerTreeViewBase::paintOpenCloseButton (Graphics& g, int width, int height, bool /*isMouseOver*/) { Path p; @@ -264,7 +264,7 @@ void JucerTreeViewBase::invokeShowDocument() showDocument(); } -void JucerTreeViewBase::itemDoubleClicked (const MouseEvent& e) +void JucerTreeViewBase::itemDoubleClicked (const MouseEvent&) { invokeShowDocument(); } diff --git a/extras/JuceDemo/Builds/MacOSX/Juce Demo.xcodeproj/project.pbxproj b/extras/JuceDemo/Builds/MacOSX/Juce Demo.xcodeproj/project.pbxproj index e7cd342719..2f6899ec50 100644 --- a/extras/JuceDemo/Builds/MacOSX/Juce Demo.xcodeproj/project.pbxproj +++ b/extras/JuceDemo/Builds/MacOSX/Juce Demo.xcodeproj/project.pbxproj @@ -2030,6 +2030,7 @@ HEADER_SEARCH_PATHS = "../../JuceLibraryCode $(inherited)"; GCC_OPTIMIZATION_LEVEL = 0; INFOPLIST_FILE = Info.plist; + OTHER_CPLUSPLUSFLAGS = "-Wall -Wno-missing-field-initializers -Wno-strict-aliasing"; INSTALL_PATH = "$(HOME)/Applications"; MACOSX_DEPLOYMENT_TARGET_ppc = 10.4; SDKROOT_ppc = macosx10.5; @@ -2049,6 +2050,7 @@ HEADER_SEARCH_PATHS = "../../JuceLibraryCode $(inherited)"; GCC_OPTIMIZATION_LEVEL = s; INFOPLIST_FILE = Info.plist; + OTHER_CPLUSPLUSFLAGS = "-Wall -Wno-missing-field-initializers -Wno-strict-aliasing"; INSTALL_PATH = "$(HOME)/Applications"; MACOSX_DEPLOYMENT_TARGET = 10.5; MACOSX_DEPLOYMENT_TARGET_ppc = 10.4; diff --git a/extras/JuceDemo/Juce Demo.jucer b/extras/JuceDemo/Juce Demo.jucer index 654e632a86..dbf5f31a4b 100644 --- a/extras/JuceDemo/Juce Demo.jucer +++ b/extras/JuceDemo/Juce Demo.jucer @@ -11,7 +11,8 @@ companyName="Raw Material Software Ltd."> + juceFolder="../../../juce" objCExtraSuffix="JSLvvV6j" bigIcon="f4hwldS" + extraCompilerFlags="-Wall -Wno-missing-field-initializers -Wno-strict-aliasing"> updateMenus (menu); diff --git a/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm b/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm index fb740d628d..a60962e660 100644 --- a/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm +++ b/modules/juce_gui_basics/native/juce_mac_NSViewComponentPeer.mm @@ -1635,7 +1635,7 @@ private: owner->sendDragCallback (1, sender); } - static BOOL prepareForDragOperation (id self, SEL, id ) + static BOOL prepareForDragOperation (id, SEL, id ) { return YES; } diff --git a/modules/juce_gui_basics/native/juce_mac_Windowing.mm b/modules/juce_gui_basics/native/juce_mac_Windowing.mm index 6dc991b0ae..f74702d6f9 100644 --- a/modules/juce_gui_basics/native/juce_mac_Windowing.mm +++ b/modules/juce_gui_basics/native/juce_mac_Windowing.mm @@ -107,7 +107,7 @@ private: void JUCE_CALLTYPE NativeMessageBox::showMessageBox (AlertWindow::AlertIconType iconType, const String& title, const String& message, - Component* associatedComponent) + Component* /*associatedComponent*/) { OSXMessageBox box (iconType, title, message, "OK", nullptr, nullptr, nullptr, false); (void) box.getResult(); @@ -115,7 +115,7 @@ void JUCE_CALLTYPE NativeMessageBox::showMessageBox (AlertWindow::AlertIconType void JUCE_CALLTYPE NativeMessageBox::showMessageBoxAsync (AlertWindow::AlertIconType iconType, const String& title, const String& message, - Component* associatedComponent) + Component* /*associatedComponent*/) { new OSXMessageBox (iconType, title, message, "OK", nullptr, nullptr, nullptr, true); } diff --git a/modules/juce_gui_basics/widgets/juce_TableListBox.cpp b/modules/juce_gui_basics/widgets/juce_TableListBox.cpp index cfb55b4fe0..45750d25cb 100644 --- a/modules/juce_gui_basics/widgets/juce_TableListBox.cpp +++ b/modules/juce_gui_basics/widgets/juce_TableListBox.cpp @@ -133,8 +133,8 @@ public: const int columnId = owner.getHeader().getColumnIdAtX (e.x); if (columnId != 0) - if (TableListBoxModel* model = owner.getModel()) - model->cellClicked (row, columnId, e); + if (TableListBoxModel* m = owner.getModel()) + m->cellClicked (row, columnId, e); } else { @@ -171,8 +171,8 @@ public: const int columnId = owner.getHeader().getColumnIdAtX (e.x); if (columnId != 0) - if (TableListBoxModel* model = owner.getModel()) - model->cellClicked (row, columnId, e); + if (TableListBoxModel* m = owner.getModel()) + m->cellClicked (row, columnId, e); } } @@ -181,8 +181,8 @@ public: const int columnId = owner.getHeader().getColumnIdAtX (e.x); if (columnId != 0) - if (TableListBoxModel* model = owner.getModel()) - model->cellDoubleClicked (row, columnId, e); + if (TableListBoxModel* m = owner.getModel()) + m->cellDoubleClicked (row, columnId, e); } String getTooltip() @@ -190,8 +190,8 @@ public: const int columnId = owner.getHeader().getColumnIdAtX (getMouseXYRelative().getX()); if (columnId != 0) - if (TableListBoxModel* model = owner.getModel()) - return model->getCellTooltip (row, columnId); + if (TableListBoxModel* m = owner.getModel()) + return m->getCellTooltip (row, columnId); return String::empty; }