From 16d5e4e2a609fa0d74ccfb1801e5bb84104598cb Mon Sep 17 00:00:00 2001 From: reuk Date: Mon, 8 Jan 2024 21:07:34 +0000 Subject: [PATCH] CIDevice: Avoid including subscribeId in replies to subscription messages --- modules/juce_midi_ci/ci/juce_CIDevice.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/juce_midi_ci/ci/juce_CIDevice.cpp b/modules/juce_midi_ci/ci/juce_CIDevice.cpp index 2a4f685b98..0bd7307781 100644 --- a/modules/juce_midi_ci/ci/juce_CIDevice.cpp +++ b/modules/juce_midi_ci/ci/juce_CIDevice.cpp @@ -927,7 +927,6 @@ private: device->listeners.call ([source, &data] (auto& l) { l.propertySubscriptionDataReceived (source, data); }); PropertyReplyHeader header; - header.extended["subscribeId"] = subscribeId; const auto headerBytes = Encodings::jsonTo7BitText (header.toVarCondensed()); detail::MessageTypeUtils::send (device->concreteBufferOutput, @@ -1192,6 +1191,9 @@ private: if (! primed.isValid()) return; + // TODO(reuk) this isn't ideal, make subscription/request handling more robust + primed.token.release(); + detail::PropertyHostUtils::send (concreteBufferOutput, options.getFunctionBlock().firstGroup, detail::MessageMeta::Meta::subID2,