mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

VST3: Fixed a hosting parameter order bug

Browse source
This commit is contained in:
Tom Poole 2020-01-02 17:04:19 +00:00
parent b1aaff50e1
commit 1610d79314
1 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
modules/juce_audio_processors/format_types/juce_VST3PluginFormat.cpp
View file

@ -1594,9 +1594,11 @@ public:
struct VST3Parameter final : public Parameter
{
VST3Parameter (VST3PluginInstance& parent,
int vstParameterIndex,
Steinberg::Vst::ParamID parameterID,
bool parameterIsAutomatable)
: pluginInstance (parent),
vstParamIndex (vstParameterIndex),
paramID (parameterID),
automatable (parameterIsAutomatable)
{
@ -1654,19 +1656,24 @@ public:
return Parameter::getValueForText (text);
}
Vst::ParameterInfo getParameterInfo() const
{
return pluginInstance.getParameterInfoForIndex (vstParamIndex);
}
float getDefaultValue() const override
{
return (float) pluginInstance.getParameterInfoForIndex (getParameterIndex()).defaultNormalizedValue;
return (float) getParameterInfo().defaultNormalizedValue;
}
String getName (int /*maximumStringLength*/) const override
{
return toString (pluginInstance.getParameterInfoForIndex (getParameterIndex()).title);
return toString (getParameterInfo().title);
}
String getLabel() const override
{
return toString (pluginInstance.getParameterInfoForIndex (getParameterIndex()).units);
return toString (getParameterInfo().units);
}
bool isAutomatable() const override
@ -1681,7 +1688,7 @@ public:
int getNumSteps() const override
{
auto stepCount = pluginInstance.getParameterInfoForIndex (getParameterIndex()).stepCount;
auto stepCount = getParameterInfo().stepCount;
return stepCount == 0 ? AudioProcessor::getDefaultNumParameterSteps()
: stepCount + 1;
}
@ -1692,6 +1699,7 @@ public:
}
VST3PluginInstance& pluginInstance;
const int vstParamIndex;
const Steinberg::Vst::ParamID paramID;
const bool automatable;
};
@ -1700,7 +1708,7 @@ public:
VST3PluginInstance (VST3ComponentHolder* componentHolder)
: AudioPluginInstance (getBusProperties (componentHolder->component)),
holder (componentHolder),
inputParameterChanges (new ParamValueQueueList()),
inputParameterChanges (new ParamValueQueueList()),
outputParameterChanges (new ParamValueQueueList()),
midiInputs (new MidiEventList()),
midiOutputs (new MidiEventList())
@ -2571,6 +2579,7 @@ private:
{
auto paramInfo = getParameterInfoForIndex (i);
auto* param = new VST3Parameter (*this,
i,
paramInfo.id,
(paramInfo.flags & Vst::ParameterInfo::kCanAutomate) != 0);
@ -2578,7 +2587,6 @@ private:
bypassParam = param;
std::function<AudioProcessorParameterGroup*(Vst::UnitID)> findOrCreateGroup;
findOrCreateGroup = [&groupMap, &infoMap, &findOrCreateGroup](Vst::UnitID groupID)
{
auto existingGroup = groupMap.find (groupID);