mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

VST3 Client: Enforce that process and setActive are not called simultaneously in FL Studio

Browse source 
Opening some JUCE VST3s in FL Studio's patcher can cause crashes because
of data races on objects accessed from setActive() and process().

According to the VST3 specification, these functions should never be
called simultaneously, so I think this is a bug in FL Studio.
This commit is contained in:
reuk 2023-02-02 14:35:58 +00:00
parent f7d01e9a5e
commit 13d27987f4
No known key found for this signature in database
GPG key ID: FCB43929F012EE5C
1 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

27
modules/juce_audio_plugin_client/VST3/juce_VST3_Wrapper.cpp
View file

@ -2551,6 +2551,8 @@ public:
//==============================================================================
tresult PLUGIN_API setActive (TBool state) override
{
const FLStudioDIYSpecificationEnforcementLock lock (flStudioDIYSpecificationEnforcementMutex);
const auto willBeActive = (state != 0);
active = false;
@ -3140,6 +3142,8 @@ public:
Steinberg::int32 index,
TBool state) override
{
const FLStudioDIYSpecificationEnforcementLock lock (flStudioDIYSpecificationEnforcementMutex);
// The host is misbehaving! The plugin must be deactivated before setting new arrangements.
jassert (! active);
@ -3274,6 +3278,8 @@ public:
tresult PLUGIN_API setBusArrangements (Vst::SpeakerArrangement* inputs, Steinberg::int32 numIns,
Vst::SpeakerArrangement* outputs, Steinberg::int32 numOuts) override
{
const FLStudioDIYSpecificationEnforcementLock lock (flStudioDIYSpecificationEnforcementMutex);
if (active)
{
// The host is misbehaving! The plugin must be deactivated before setting new arrangements.
@ -3501,6 +3507,8 @@ public:
tresult PLUGIN_API process (Vst::ProcessData& data) override
{
const FLStudioDIYSpecificationEnforcementLock lock (flStudioDIYSpecificationEnforcementMutex);
if (pluginInstance == nullptr)
return kResultFalse;
@ -3573,6 +3581,24 @@ public:
}
private:
/* FL's Patcher implements the VST3 specification incorrectly, calls process() before/during
setActive().
*/
class [[nodiscard]] FLStudioDIYSpecificationEnforcementLock
{
public:
explicit FLStudioDIYSpecificationEnforcementLock (CriticalSection& mutex)
{
static const auto lockRequired = PluginHostType().isFruityLoops();
if (lockRequired)
lock.emplace (mutex);
}
private:
std::optional<ScopedLock> lock;
};
InterfaceResultWithDeferredAddRef queryInterfaceInternal (const TUID targetIID)
{
const auto result = testForMultiple (*this,
@ -3790,6 +3816,7 @@ private:
#endif
static const char* kJucePrivateDataIdentifier;
CriticalSection flStudioDIYSpecificationEnforcementMutex;
JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (JuceVST3Component)
};