From 12256536a387ffdebe58f5d8d03f145272d44213 Mon Sep 17 00:00:00 2001
From: tpoole <tom@tp-mbp.local>
Date: Mon, 28 Nov 2016 17:17:42 +0000
Subject: [PATCH] Fixed bug when setting AudioProcessorValueTreeState values
 before listeners are registered

---
 .../juce_AudioProcessorValueTreeState.cpp     | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp b/modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp
index 22a08c8041..031eadf436 100644
--- a/modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp
+++ b/modules/juce_audio_processors/utilities/juce_AudioProcessorValueTreeState.cpp
@@ -420,8 +420,10 @@ struct AudioProcessorValueTreeState::SliderAttachment::Pimpl  : private Attached
     {
         const ScopedLock selfCallbackLock (selfCallbackMutex);
 
-        ignoreCallbacks = true;
-        slider.setValue (newValue, sendNotificationSync);
+        {
+            ScopedValueSetter<bool> svs (ignoreCallbacks, true);
+            slider.setValue (newValue, sendNotificationSync);
+        }
     }
 
     void sliderValueChanged (Slider* s) override
@@ -430,8 +432,6 @@ struct AudioProcessorValueTreeState::SliderAttachment::Pimpl  : private Attached
 
         if ((! ignoreCallbacks) && (! ModifierKeys::getCurrentModifiers().isRightButtonDown()))
             setNewUnnormalisedValue ((float) s->getValue());
-
-        ignoreCallbacks = false;
     }
 
     void sliderDragStarted (Slider*) override { beginParameterChange(); }
@@ -472,8 +472,10 @@ struct AudioProcessorValueTreeState::ComboBoxAttachment::Pimpl  : private Attach
     {
         const ScopedLock selfCallbackLock (selfCallbackMutex);
 
-        ignoreCallbacks = true;
-        combo.setSelectedItemIndex (roundToInt (newValue), sendNotificationSync);
+        {
+            ScopedValueSetter<bool> svs (ignoreCallbacks, true);
+            combo.setSelectedItemIndex (roundToInt (newValue), sendNotificationSync);
+        }
     }
 
     void comboBoxChanged (ComboBox* comboBox) override
@@ -486,7 +488,6 @@ struct AudioProcessorValueTreeState::ComboBoxAttachment::Pimpl  : private Attach
             setNewUnnormalisedValue ((float) comboBox->getSelectedId() - 1.0f);
             endParameterChange();
         }
-        ignoreCallbacks = false;
     }
 
     ComboBox& combo;
@@ -524,8 +525,10 @@ struct AudioProcessorValueTreeState::ButtonAttachment::Pimpl  : private Attached
     {
         const ScopedLock selfCallbackLock (selfCallbackMutex);
 
-        ignoreCallbacks = true;
-        button.setToggleState (newValue >= 0.5f, sendNotificationSync);
+        {
+            ScopedValueSetter<bool> svs (ignoreCallbacks, true);
+            button.setToggleState (newValue >= 0.5f, sendNotificationSync);
+        }
     }
 
     void buttonClicked (Button* b) override
@@ -538,7 +541,6 @@ struct AudioProcessorValueTreeState::ButtonAttachment::Pimpl  : private Attached
             setNewUnnormalisedValue (b->getToggleState() ? 1.0f : 0.0f);
             endParameterChange();
         }
-        ignoreCallbacks = false;
     }
 
     Button& button;