mirror/JUCE
1
0
Fork 0
mirror of https://github.com/juce-framework/JUCE.git synced 2026-01-10 23:44:24 +00:00
Code Activity

OpenGLFrameBuffer: Keep track of the previously-bound framebuffer

Browse source
This commit is contained in:
reuk 2025-05-14 17:24:00 +01:00
parent b15b65decf
commit 00836d1e94
No known key found for this signature in database
1 changed files with 41 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

56
modules/juce_opengl/opengl/juce_OpenGLFrameBuffer.cpp
View file

@ -38,6 +38,24 @@ namespace juce
class OpenGLFrameBuffer::Pimpl class OpenGLFrameBuffer::Pimpl
{ {
public: public:
/* Stores the currently-bound texture on construction, and re-binds it on destruction. */
struct ScopedTextureBinding
{
ScopedTextureBinding()
{
glGetIntegerv (GL_TEXTURE_BINDING_2D, &prev);
JUCE_CHECK_OPENGL_ERROR
}
~ScopedTextureBinding()
{
glBindTexture (GL_TEXTURE_2D, (GLuint) prev);
JUCE_CHECK_OPENGL_ERROR
}
GLint prev{};
};
Pimpl (OpenGLContext& c, const int w, const int h, Pimpl (OpenGLContext& c, const int w, const int h,
const bool wantsDepthBuffer, const bool wantsStencilBuffer) const bool wantsDepthBuffer, const bool wantsStencilBuffer)
: context (c), width (w), height (h), : context (c), width (w), height (h),
@ -56,18 +74,22 @@ public:
context.extensions.glGenFramebuffers (1, &frameBufferID); context.extensions.glGenFramebuffers (1, &frameBufferID);
bind(); bind();
glGenTextures (1, &textureID); {
glBindTexture (GL_TEXTURE_2D, textureID); const ScopedTextureBinding scopedTextureBinding;
JUCE_CHECK_OPENGL_ERROR
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glGenTextures (1, &textureID);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glBindTexture (GL_TEXTURE_2D, textureID);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); JUCE_CHECK_OPENGL_ERROR
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
JUCE_CHECK_OPENGL_ERROR
glTexImage2D (GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr); glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
JUCE_CHECK_OPENGL_ERROR glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
glTexParameteri (GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
JUCE_CHECK_OPENGL_ERROR
glTexImage2D (GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
JUCE_CHECK_OPENGL_ERROR
}
context.extensions.glFramebufferTexture2D (GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, textureID, 0); context.extensions.glFramebufferTexture2D (GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, textureID, 0);
@ -124,13 +146,14 @@ public:
void bind() void bind()
{ {
glGetIntegerv (GL_FRAMEBUFFER_BINDING, &prevFramebuffer);
context.extensions.glBindFramebuffer (GL_FRAMEBUFFER, frameBufferID); context.extensions.glBindFramebuffer (GL_FRAMEBUFFER, frameBufferID);
JUCE_CHECK_OPENGL_ERROR JUCE_CHECK_OPENGL_ERROR
} }
void unbind() void unbind()
{ {
context.extensions.glBindFramebuffer (GL_FRAMEBUFFER, context.getFrameBufferID()); context.extensions.glBindFramebuffer (GL_FRAMEBUFFER, (GLuint) prevFramebuffer);
JUCE_CHECK_OPENGL_ERROR JUCE_CHECK_OPENGL_ERROR
} }
@ -140,6 +163,8 @@ public:
bool hasDepthBuffer, hasStencilBuffer; bool hasDepthBuffer, hasStencilBuffer;
private: private:
GLint prevFramebuffer{};
bool checkStatus() noexcept bool checkStatus() noexcept
{ {
const GLenum status = context.extensions.glCheckFramebufferStatus (GL_FRAMEBUFFER); const GLenum status = context.extensions.glCheckFramebufferStatus (GL_FRAMEBUFFER);
@ -230,10 +255,11 @@ bool OpenGLFrameBuffer::initialise (OpenGLFrameBuffer& other)
clearGLError(); clearGLError();
#endif #endif
glBindTexture (GL_TEXTURE_2D, p->textureID); {
pimpl->context.copyTexture (area, area, area.getWidth(), area.getHeight(), false); const Pimpl::ScopedTextureBinding scopedTextureBinding;
glBindTexture (GL_TEXTURE_2D, 0); glBindTexture (GL_TEXTURE_2D, p->textureID);
JUCE_CHECK_OPENGL_ERROR pimpl->context.copyTexture (area, area, area.getWidth(), area.getHeight(), false);
}
pimpl->unbind(); pimpl->unbind();
return true; return true;